From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 971DC386189F for ; Fri, 3 Jul 2020 11:24:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 971DC386189F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CC406AF6E; Fri, 3 Jul 2020 11:24:34 +0000 (UTC) Subject: Re: [committed][gdb/testsuite] Update psym-external-decl.exp for gcc-10/clang To: Pedro Alves , Gary Benson Cc: gdb-patches@sourceware.org References: <20200617122432.GA28940@blade.nx> <20200618161044.GA1032@blade.nx> <21d9fcc8-62c4-d1a5-f085-0c7f26783255@suse.de> <20200619140041.GB31823@blade.nx> <6dd30362-e9dd-6bc9-bf40-8b846b926e5a@suse.de> <20200626093727.GA8682@blade.nx> <20200703092107.GA8482@blade.nx> From: Tom de Vries Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: <5197d5fc-1a9d-b61d-71a5-864b2133f13b@suse.de> Date: Fri, 3 Jul 2020 13:24:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jul 2020 11:24:37 -0000 On 7/3/20 1:20 PM, Pedro Alves wrote: > On 7/3/20 10:21 AM, Gary Benson wrote: >> Tom de Vries wrote: >>> On 6/29/20 2:32 PM, Pedro Alves wrote: > >>>> I would suggest filing a bug with clang, to confirm whether >>>> this is intentional, or whether they see it as a bug. I would >>>> think it is a bug, but I'm not sure. If indeed a bug, we would >>>> XFAIL the test. >>> >>> I've filed https://bugs.llvm.org/show_bug.cgi?id=46514 . >>> >>> Thanks, >>> - Tom >> >> Thank for filing it Tom. > > So the conclusion seems to be that the testcase should be using > -fstandalone-debug? > > Except, I tried it here, and it doesn't seem to work: > It is my understanding that -fstandalone-debug should be used for clang, but that is doesn't work atm, which is a problem in clang/llvm that is tracked in the PR. Thanks, - Tom > ~~~~~~~~~~~~~~~~ > From 792aa03ab3325fe7cfcfeb51e765e81da2fbbfaf Mon Sep 17 00:00:00 2001 > From: Pedro Alves > Date: Fri, 3 Jul 2020 12:12:19 +0100 > Subject: [PATCH] standalone > > --- > gdb/testsuite/gdb.base/psym-external-decl.exp | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/gdb/testsuite/gdb.base/psym-external-decl.exp b/gdb/testsuite/gdb.base/psym-external-decl.exp > index d0388d5655e..faff3234bb5 100644 > --- a/gdb/testsuite/gdb.base/psym-external-decl.exp > +++ b/gdb/testsuite/gdb.base/psym-external-decl.exp > @@ -15,17 +15,18 @@ > > standard_testfile .c psym-external-decl-2.c > > +set srcfiles [list $srcfile $srcfile2] > +set options {debug} > + > get_compiler_info > if { [test_compiler_info "clang-*"] } { > - return -1 > + lappend options additional_flags=-fstandalone-debug > } > > -set srcfiles [list $srcfile $srcfile2] > - > if { [build_executable_from_specs \ > "failed to prepare" \ > $testfile [list] \ > - $srcfile [list debug] \ > + $srcfile $options \ > $srcfile2 [list]] == -1 } { > return -1 > } > > base-commit: c2ecccb33c307faa21f4d2f47348e7346b032d94 >