From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16442 invoked by alias); 16 May 2013 10:18:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16433 invoked by uid 89); 16 May 2013 10:18:54 -0000 X-Spam-SWARE-Status: No, score=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 16 May 2013 10:18:54 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4GAIqgC026482 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 16 May 2013 06:18:52 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r4GAIoq1006245; Thu, 16 May 2013 06:18:50 -0400 Message-ID: <5194B289.5080206@redhat.com> Date: Thu, 16 May 2013 10:18:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Joel Brobecker CC: Keith Seitz , Sergio Durigan Junior , "gdb-patches@sourceware.org ml" Subject: Re: [RFA] completer test [was Re: [RFC] Cleanup for make_source_files_completion_list] References: <51895A2F.8000504@redhat.com> <5191340B.60100@redhat.com> <519156F5.5090000@redhat.com> <5193C786.4000207@redhat.com> <5193E2DC.5000200@redhat.com> <51941E85.8010104@redhat.com> <5194A48D.4060806@redhat.com> <20130516092601.GI5555@adacore.com> In-Reply-To: <20130516092601.GI5555@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00585.txt.bz2 On 05/16/2013 10:26 AM, Joel Brobecker wrote: >> Please use gdb_test_multiple. See e.g., how completion.exp itself >> simplified much when converted to it: >> >> http://sourceware.org/ml/gdb-patches/2011-05/msg00063.html > > I also just checked in a test that performs a completion test > using send_gdb + gdb_test_multiple... > > http://www.sourceware.org/ml/gdb-patches/2013-05/msg00573.html Ah, > --- a/gdb/testsuite/gdb.ada/complete.exp > +++ b/gdb/testsuite/gdb.ada/complete.exp > @@ -175,4 +175,19 @@ test_gdb_complete "pck." \ > test_gdb_complete " "p " ... That made me look at what test_gdb_complete is, and then I noticed a FIXME that's super easily fixed nowadays. :-) http://sourceware.org/ml/gdb-patches/2013-05/msg00584.html I went ahead and checked in the fix as obvious. -- Pedro Alves