From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21659 invoked by alias); 16 May 2013 09:38:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21648 invoked by uid 89); 16 May 2013 09:38:33 -0000 X-Spam-SWARE-Status: No, score=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 16 May 2013 09:38:32 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4G9cT9h031983 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 16 May 2013 05:38:29 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r4G9cRpc009672; Thu, 16 May 2013 05:38:28 -0400 Message-ID: <5194A913.3050704@redhat.com> Date: Thu, 16 May 2013 09:38:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Stan Shebs CC: gdb-patches@sourceware.org Subject: Re: [RFA] completer test [was Re: [RFC] Cleanup for make_source_files_completion_list] References: <51895A2F.8000504@redhat.com> <5191340B.60100@redhat.com> <519156F5.5090000@redhat.com> <5193C786.4000207@redhat.com> <5193E2DC.5000200@redhat.com> <51941E85.8010104@redhat.com> <519427DD.3080001@earthlink.net> In-Reply-To: <519427DD.3080001@earthlink.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00583.txt.bz2 On 05/16/2013 01:27 AM, Stan Shebs wrote: > It may even be that gdb_test_multiple suffices for all of the existing > send_gdb/gdb_expect pairs, but I don't imagine anyone has the fortitude > to work through every one of them. :-) Michael Snyder went through a lot of them in 2010. E.g., 2010-06-02 Michael Snyder * gdb.trace/actions.exp: Use gdb_test_no_output. * gdb.trace/circ.exp: Ditto. * gdb.trace/packetlen.exp: Ditto. * gdb.trace/save-trace.exp: Ditto. ... 2010-05-28 Michael Snyder * gdb.reverse/break-precsave.exp: Replace uses of send_gdb / gdb_expect. * gdb.reverse/break-reverse.exp: ... (many others) We have a lot less remaining uses of gdb_expect in tests since, but we do still have many more than I expected. I'm a bit surprised; I thought we had fewer: early 2010 tree: $ find . -name "*.exp" | grep -v "lib/" | xargs grep gdb_expect | wc -l 1849 vs current tree: $ find . -name "*.exp" | grep -v "lib/" | xargs grep gdb_expect | wc -l 739 -- Pedro Alves