Re: [RFA] completer test [was Re: [RFC] Cleanup for make_source_files_completion_list]

Joel Brobecker
2013-05-16T05:30:19Z

> > (gdb) complete break filesy
> > break filesym
> > break filesym.c
>
> Is that necessarily "better" than testing what a user would actually
> type? I don't know. gdb.base/completion.exp uses both forms.

I haven't verified yet that the issue you fixed is the same as
the issue I noticed, and put aside for later. But my initial
investigation at the time showed that the problem did not appear
when using the "complete" command, only when using the interactive
form via the "tab" key.

> >Also, ISTR "send_gdb" is deprecated, and one should use
> >"gdb_test_multiple" instead. WDYT?
>
> Is send_gdb deprecated or gdb_expect? Or is their direct use discouraged?

My take on this is that it is very highly discouraged, at least
for gdb_expect, and should only be used when none of the standard
gdb_test et al routines can do the job. The reason behind it is
that using gdb_expect directly, you are missing out on the standard
processing of various known conditions (internal errors, timeouts,
etc).

--
Joel