[RFA] completer test [was Re: [RFC] Cleanup for make_source_files_completion_list]

Keith Seitz
2013-05-15T19:32:51Z

[-- Attachment #1: Type: text/plain, Size: 609 bytes --]

On 05/15/2013 10:36 AM, Keith Seitz wrote:
> $ cat same.c
> int
> same (int a)
> {
> return a;
> }
>
> int
> main (void)
> {
> return same (0);
> }
> $ gcc -g same.c -o same
> $ gdb -q same
> (gdb) b same.\t\t
> [blah blah blah]
> c
> same
> (gdb)
>
> Compare this with unpatched gdb:
> (gdb) b same.\t\t
> [blah blah blah]
> same.c
> same
>
> So this needs to stay put. I'll see if I can generate a test case for this.

And here is the test case.

Keith

testsuite/ChangeLog
2013-05-15 Keith Seitz <keiths@redhat.com>

* gdb.base/filesym.exp: New completer test.
* gdb.base/filesym.c: New file.

[-- Attachment #2: completer-test.patch --]
[-- Type: text/x-patch, Size: 2804 bytes --]

diff --git a/gdb/testsuite/gdb.base/filesym.c b/gdb/testsuite/gdb.base/filesym.c
new file mode 100644
index 0000000..11b3b25
--- /dev/null
+++ b/gdb/testsuite/gdb.base/filesym.c
@@ -0,0 +1,28 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+ Copyright 2013 Free Software Foundation, Inc.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>. */
+
+int
+filesym (int arg)
+{
+ return arg;
+}
+
+int
+main (void)
+{
+ return filesym (0);
+}
diff --git a/gdb/testsuite/gdb.base/filesym.exp b/gdb/testsuite/gdb.base/filesym.exp
new file mode 100644
index 0000000..c9e9c20
--- /dev/null
+++ b/gdb/testsuite/gdb.base/filesym.exp
@@ -0,0 +1,50 @@
+# Copyright 2013 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+# This series of completion tests checks the completion output
+# on a name which is potentially both a symbol name and a file name.
+
+standard_testfile
+
+if {[prepare_for_testing $testfile.exp $testfile $srcfile debug]} {
+ return -1
+}
+
+# Test completion list for "filesy". We expect the immediate result to
+# complete to "filesym"; completing again, we expect the symbol name and the
+# filename (in that order).
+
+send_gdb "break filesy\t"
+gdb_expect {
+ -re "m\$" {
+ pass "complete on \"filesy\""
+
+ # Now ask for the completion list
+ send_gdb "\t\t"
+ gdb_expect {
+ -re ".*filesym\[ \t\]+filesym.c.*$gdb_prompt break filesym\$" {
+ pass "completion list for \"filesym\""
+ }
+
+ default {
+ fail "completion list for \"filesym\""
+ }
+ }
+ }
+
+ default {
+ fail "complete on \"filesy\""
+ }
+}