Re: [RFA] completer test [was Re: [RFC] Cleanup for make_source_files_completion_list]

Tom Tromey
2013-05-17T16:27:21Z

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> I suspect we are going to find a large number of issues in
Joel> ada-lang, simply because I never quite grasped the fact that
Joel> cleanups should not be leaked under normal execution (only
Joel> when an exception is raised, in which case they get automatically
Joel> performed).

The checker found two -- the one you fixed in
ada_make_symbol_completion_list, and also a dangling cleanup in
old_renaming_is_invisible. This one seemed hard to fix and so
in my patch series I just punted on it by marking it with
the dangling_cleanup attribute.

Tom