Checked in: [RFA] completer test [was Re: [RFC] Cleanup for make_source_files_completion_list]

Joel Brobecker
2013-05-21T05:43:43Z

> Joel> Do you see something obviously wrong with the attached patch?
> Joel> I haven't tested it yet, and I am not sure how much I can test it,
> Joel> given that old-style renamings have been replaced 6 years ago.
> Joel> I was looking at the option of removing support for them, but
> Joel> I actually know of some users still using an ancient version
> Joel> of the compiler but with a new version of the debugger...
>
> For some reason I thought the function needed to leave a dangling
> cleanup, but I see now I was mistaken.
> It looks good to me.

Cool, thanks! Attached is what I checked in, after a round of testing on
x86_64-linux.

gdb/ChangeLog:

* ada-lang.c (old_renaming_is_invisible): Fix cleanup leak.

Thanks again for pointing this cleanup leak out.

--
Joel