Re: [RFC] Cleanup for make_source_files_completion_list

Keith Seitz
2013-05-15T17:36:09Z

On 05/13/2013 02:11 PM, Keith Seitz wrote:
> On 05/13/2013 11:42 AM, Keith Seitz wrote:
>> However, I think that the comment quoted above (and the surrounding
>> block of code which does the copying) should be removed and the callers
>> of make_source_files_completion list should pass text AND word instead
>> of text and text. add_filename_to_list (in symtab.c) does this text -
>> word adjustment already, so it is not necessary to repeat it here. WDYT?
>
> Something like this? [This causes no regressions in the test suite or by
> manually hacking at it.]

Ok, no, this won't work either. The text in the comment (which I
proposed to remove) hints at the problem:

$ cat same.c
int
same (int a)
{
return a;
}

int
main (void)
{
return same (0);
}
$ gcc -g same.c -o same
$ gdb -q same
(gdb) b same.\t\t
[blah blah blah]
c
same
(gdb)

Compare this with unpatched gdb:
(gdb) b same.\t\t
[blah blah blah]
same.c
same

So this needs to stay put. I'll see if I can generate a test case for this.

Thanks to Tom for bringing this up.

Keith