Re: [RFA] completer test [was Re: [RFC] Cleanup for make_source_files_completion_list]

Joel Brobecker
2013-05-20T05:28:31Z

[-- Attachment #1: Type: text/plain, Size: 657 bytes --]

> The checker found two -- the one you fixed in
> ada_make_symbol_completion_list, and also a dangling cleanup in
> old_renaming_is_invisible. This one seemed hard to fix and so
> in my patch series I just punted on it by marking it with
> the dangling_cleanup attribute.

Do you see something obviously wrong with the attached patch?
I haven't tested it yet, and I am not sure how much I can test it,
given that old-style renamings have been replaced 6 years ago.
I was looking at the option of removing support for them, but
I actually know of some users still using an ancient version
of the compiler but with a new version of the debugger...

--
Joel

[-- Attachment #2: old_renaming_is_invisible-cleanup.diff --]
[-- Type: text/x-diff, Size: 1244 bytes --]

diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index fa6db0f..b6d5e0b 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -4726,17 +4726,20 @@ static int
old_renaming_is_invisible (const struct symbol *sym, const char *function_name)
{
char *scope;
+ struct cleanup *old_chain;

if (SYMBOL_CLASS (sym) != LOC_TYPEDEF)
return 0;

scope = xget_renaming_scope (SYMBOL_TYPE (sym));
-
- make_cleanup (xfree, scope);
+ old_chain = make_cleanup (xfree, scope);

/* If the rename has been defined in a package, then it is visible. */
if (is_package_name (scope))
- return 0;
+ {
+ do_cleanups (old_chain);
+ return 0;
+ }

/* Check that the rename is in the current function scope by checking
that its name starts with SCOPE. */
@@ -4748,7 +4751,12 @@ old_renaming_is_invisible (const struct symbol *sym, const char *function_name)
if (strncmp (function_name, "_ada_", 5) == 0)
function_name += 5;

- return (strncmp (function_name, scope, strlen (scope)) != 0);
+ {
+ int is_invisible = strncmp (function_name, scope, strlen (scope)) != 0;
+
+ do_cleanups (old_chain);
+ return is_invisible;
+ }
}

/* Remove entries from SYMS that corresponds to a renaming entity that