Re: [RFA] completer test [was Re: [RFC] Cleanup for make_source_files_completion_list]

Pedro Alves
2013-05-16T09:38:33Z

On 05/16/2013 01:27 AM, Stan Shebs wrote:
> It may even be that gdb_test_multiple suffices for all of the existing
> send_gdb/gdb_expect pairs, but I don't imagine anyone has the fortitude
> to work through every one of them. :-)

Michael Snyder went through a lot of them in 2010. E.g.,

2010-06-02 Michael Snyder <msnyder@vmware.com>

* gdb.trace/actions.exp: Use gdb_test_no_output.
* gdb.trace/circ.exp: Ditto.
* gdb.trace/packetlen.exp: Ditto.
* gdb.trace/save-trace.exp: Ditto.
...
2010-05-28 Michael Snyder <msnyder@vmware.com>

* gdb.reverse/break-precsave.exp:
Replace uses of send_gdb / gdb_expect.
* gdb.reverse/break-reverse.exp:
...
(many others)

We have a lot less remaining uses of gdb_expect in tests since, but
we do still have many more than I expected. I'm a bit surprised;
I thought we had fewer:

early 2010 tree:
$ find . -name "*.exp" | grep -v "lib/" | xargs grep gdb_expect | wc -l
1849

vs current tree:
$ find . -name "*.exp" | grep -v "lib/" | xargs grep gdb_expect | wc -l
739

--
Pedro Alves