From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31937 invoked by alias); 15 May 2013 19:32:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31910 invoked by uid 89); 15 May 2013 19:32:48 -0000 X-Spam-SWARE-Status: No, score=-7.3 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 15 May 2013 19:32:47 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4FJWjlX022607 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 15 May 2013 15:32:45 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r4FJWigN006263 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 15 May 2013 15:32:45 -0400 Message-ID: <5193E2DC.5000200@redhat.com> Date: Wed, 15 May 2013 19:32:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5 MIME-Version: 1.0 To: "gdb-patches@sourceware.org ml" Subject: [RFA] completer test [was Re: [RFC] Cleanup for make_source_files_completion_list] References: <51895A2F.8000504@redhat.com> <5191340B.60100@redhat.com> <519156F5.5090000@redhat.com> <5193C786.4000207@redhat.com> In-Reply-To: <5193C786.4000207@redhat.com> Content-Type: multipart/mixed; boundary="------------020106010507040606090202" X-Virus-Found: No X-SW-Source: 2013-05/txt/msg00558.txt.bz2 This is a multi-part message in MIME format. --------------020106010507040606090202 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 609 On 05/15/2013 10:36 AM, Keith Seitz wrote: > $ cat same.c > int > same (int a) > { > return a; > } > > int > main (void) > { > return same (0); > } > $ gcc -g same.c -o same > $ gdb -q same > (gdb) b same.\t\t > [blah blah blah] > c > same > (gdb) > > Compare this with unpatched gdb: > (gdb) b same.\t\t > [blah blah blah] > same.c > same > > So this needs to stay put. I'll see if I can generate a test case for this. And here is the test case. Keith testsuite/ChangeLog 2013-05-15 Keith Seitz * gdb.base/filesym.exp: New completer test. * gdb.base/filesym.c: New file. --------------020106010507040606090202 Content-Type: text/x-patch; name="completer-test.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="completer-test.patch" Content-length: 2804 diff --git a/gdb/testsuite/gdb.base/filesym.c b/gdb/testsuite/gdb.base/filesym.c new file mode 100644 index 0000000..11b3b25 --- /dev/null +++ b/gdb/testsuite/gdb.base/filesym.c @@ -0,0 +1,28 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2013 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +int +filesym (int arg) +{ + return arg; +} + +int +main (void) +{ + return filesym (0); +} diff --git a/gdb/testsuite/gdb.base/filesym.exp b/gdb/testsuite/gdb.base/filesym.exp new file mode 100644 index 0000000..c9e9c20 --- /dev/null +++ b/gdb/testsuite/gdb.base/filesym.exp @@ -0,0 +1,50 @@ +# Copyright 2013 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# This series of completion tests checks the completion output +# on a name which is potentially both a symbol name and a file name. + +standard_testfile + +if {[prepare_for_testing $testfile.exp $testfile $srcfile debug]} { + return -1 +} + +# Test completion list for "filesy". We expect the immediate result to +# complete to "filesym"; completing again, we expect the symbol name and the +# filename (in that order). + +send_gdb "break filesy\t" +gdb_expect { + -re "m\$" { + pass "complete on \"filesy\"" + + # Now ask for the completion list + send_gdb "\t\t" + gdb_expect { + -re ".*filesym\[ \t\]+filesym.c.*$gdb_prompt break filesym\$" { + pass "completion list for \"filesym\"" + } + + default { + fail "completion list for \"filesym\"" + } + } + } + + default { + fail "complete on \"filesy\"" + } +} --------------020106010507040606090202--