From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4864 invoked by alias); 15 May 2013 16:43:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4854 invoked by uid 89); 15 May 2013 16:43:34 -0000 X-Spam-SWARE-Status: No, score=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 15 May 2013 16:43:34 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4FGhWCU014232 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 15 May 2013 12:43:32 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4FGhVed025881; Wed, 15 May 2013 12:43:31 -0400 Message-ID: <5193BB32.8080407@redhat.com> Date: Wed, 15 May 2013 16:43:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Doug Evans CC: Tom Tromey , gdb-patches Subject: Re: [PATCH 18/28] check gdb_python_initialized everywhere References: <87ehe638ww.fsf@fleche.redhat.com> <87vc7iy49l.fsf@fleche.redhat.com> <87zjwqqv2u.fsf@fleche.redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00547.txt.bz2 On 05/07/2013 07:05 PM, Doug Evans wrote: > On Tue, May 7, 2013 at 10:57 AM, Doug Evans wrote: >> On Mon, Apr 22, 2013 at 11:27 AM, Tom Tromey wrote: >>>>>>>> "Tom" == Tom Tromey writes: >>> >>> Tom> While sending out the series I realized I had meant to write a test case >>> Tom> for this patch but forgot to. I will hold on to this one until I write >>> Tom> it. >>> >>> This required a two-part series. >>> >>> The first patch just cleans up the existing gdb.gdb tests to remove >>> duplication and to make it simpler to add new tests here. >>> >>> The second patch is the actual test case. >>> >>> Built and regtested on x86-64 Fedora 18. >> >> Hi. >> I could use selftest-support in a test I'm writing. >> >> Can you check this in? >> TIA > > Blech. I never liked adding one's name to files. > The data is useless after a few years and does a disservice to all > those who come after. I agree. I see I ended up with my name mentioned in a couple tests. I think I'll remove it. I saw that glibc recently-ish started rejecting submissions that included "contributed by"/"written by"/etc. statements, even. > > I bring this up because this text in python-selftest.exp is completely bogus. > > +# This file was written by Andrew Cagney (cagney at redhat dot com), > +# derived from xfullpath.exp (written by Joel Brobecker), derived from > +# selftest.exp (written by Rob Savoye). -- Pedro Alves