From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28931 invoked by alias); 15 May 2013 16:29:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28921 invoked by uid 89); 15 May 2013 16:29:00 -0000 X-Spam-SWARE-Status: No, score=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 15 May 2013 16:28:59 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4FGSwRx029693 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 15 May 2013 12:28:58 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4FGSuQY025145; Wed, 15 May 2013 12:28:57 -0400 Message-ID: <5193B7C8.8050909@redhat.com> Date: Wed, 15 May 2013 16:29:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH 05/28] py-cmd.c error-checking bug fix References: <87ehe638ww.fsf@fleche.redhat.com> <87fvym1tmo.fsf@fleche.redhat.com> <5193B15C.8080907@redhat.com> <87bo8c2p0h.fsf@fleche.redhat.com> In-Reply-To: <87bo8c2p0h.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00546.txt.bz2 On 05/15/2013 05:20 PM, Tom Tromey wrote: > Pedro> Shouldn't this be 'malloc_failure (0)' instead of returning NULL? > > In the Python layer we follow Python conventions for error handling. > Here, PyList_New failed and set the Python exception. > We just propagate that to our caller. I see. Thanks for the explanation. -- Pedro Alves