From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5621 invoked by alias); 15 May 2013 16:01:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5587 invoked by uid 89); 15 May 2013 16:01:36 -0000 X-Spam-SWARE-Status: No, score=-7.9 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS,TW_RG autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 15 May 2013 16:01:35 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4FG1YKr001724 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 15 May 2013 12:01:34 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r4FG1W3J008977; Wed, 15 May 2013 12:01:33 -0400 Message-ID: <5193B15C.8080907@redhat.com> Date: Wed, 15 May 2013 16:01:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH 05/28] py-cmd.c error-checking bug fix References: <87ehe638ww.fsf@fleche.redhat.com> <87fvym1tmo.fsf@fleche.redhat.com> In-Reply-To: <87fvym1tmo.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00540.txt.bz2 On 04/19/2013 03:29 PM, Tom Tromey wrote: > diff --git a/gdb/python/py-cmd.c b/gdb/python/py-cmd.c > index 3da9960..ca9e415 100644 > --- a/gdb/python/py-cmd.c > +++ b/gdb/python/py-cmd.c > @@ -668,6 +668,8 @@ gdbpy_string_to_argv (PyObject *self, PyObject *args) > return NULL; > > py_argv = PyList_New (0); > + if (py_argv == NULL) > + return NULL; > Shouldn't this be 'malloc_failure (0)' instead of returning NULL? -- Pedro Alves