From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23251 invoked by alias); 15 May 2013 15:49:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23242 invoked by uid 89); 15 May 2013 15:49:08 -0000 X-Spam-SWARE-Status: No, score=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 15 May 2013 15:49:07 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4FFn6Br002041 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 15 May 2013 11:49:06 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r4FFn4nK001275; Wed, 15 May 2013 11:49:05 -0400 Message-ID: <5193AE6F.6030009@redhat.com> Date: Wed, 15 May 2013 15:49:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Tom Tromey CC: Andreas Kaufmann , "gdb-patches@sourceware.org" Subject: Re: [PATCH] Fix for 15072: stopped response missing for reverse-finish References: <5570CCEF7886EE48BAAD632645A58FDA12829B3A@DE02WEMBXB.internal.synopsys.com> <87haivlkna.fsf@fleche.redhat.com> In-Reply-To: <87haivlkna.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00538.txt.bz2 On 04/24/2013 09:48 PM, Tom Tromey wrote: >>>>>> "Andreas" == Andreas Kaufmann writes: > > Andreas> The above is not done (and nor needed) for "reverse-finish". So > Andreas> I added additional check "execution_direction != EXEC_REVERSE" > Andreas> to ensure that observer_notify_normal_stop() is called for > Andreas> "reverse-finish" from normal_stop() in gdb/infrun.c. > > It seems reasonable to me (though this isn't really my area and so Pedro > should probably weigh in). Looks good to me too. > I think a test case is needed. Agreed. > > But that will probably push the patch over the limit where we need > copyright papers (unless maybe there is some way to see the bug with the > CLI and the test case can be added to an existing file). Yes, there's an MI one even. gdb.mi/mi-reverse.exp. > Contact me > off-list to get started on that; or if you already have them in place > and I forgot, just mention it. Thanks. Thanks, -- Pedro Alves