From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1496 invoked by alias); 15 May 2013 14:14:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1484 invoked by uid 89); 15 May 2013 14:14:46 -0000 X-Spam-SWARE-Status: No, score=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 15 May 2013 14:14:46 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4FEEgMS001867 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 15 May 2013 10:14:42 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4FEEd4d012860; Wed, 15 May 2013 10:14:40 -0400 Message-ID: <5193984F.6010102@redhat.com> Date: Wed, 15 May 2013 14:14:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: lgustavo@codesourcery.com CC: "'gdb-patches@sourceware.org'" , Mike Frysinger Subject: Re: [RFC, gdbserver] Avoid defining linux_read_offsets when the target does not need it References: <519370AE.50908@codesourcery.com> In-Reply-To: <519370AE.50908@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00530.txt.bz2 On 05/15/2013 12:25 PM, Luis Machado wrote: > * linux-low.c: Move definition checks upwards for PT_TEXT_ADDR, > PT_DATA_ADDR and PT_TEXT_END_ADDR. Update comments. > (linux_read_offsets): Remove PT_TEXT_ADDR, PT_DATA_ADDR and > PT_TEXT_END_ADDR guards. Update comments. > (linux_target_op) linux_read_offsets if the target is UCLIBC and if it defines > PT_TEXT_ADDR, PT_DATA_ADDR and PT_TEXT_END_ADDR. This is OK. > +#if defined(__mcoldfire__) > +/* These are still undefined in recent (3.10) kernels. */ > +#define PT_TEXT_ADDR 49*4 > +#define PT_DATA_ADDR 50*4 > +#define PT_TEXT_END_ADDR 51*4 > +/* BFIN already defines these constants in recent (3.10) kernels. */ > +#elif defined(BFIN) > +#define PT_TEXT_ADDR 220 > +#define PT_TEXT_END_ADDR 224 > +#define PT_DATA_ADDR 228 > +/* These are still undefined in recent (3.10) kernels. */ But please avoid "recent" "new", etc. in code. Those get old fast. Thanks, -- Pedro Alves