From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7632 invoked by alias); 15 May 2013 10:46:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7621 invoked by uid 89); 15 May 2013 10:46:09 -0000 X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 15 May 2013 10:46:07 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UcZDi-00030j-AX from Muhammad_Bilal@mentor.com ; Wed, 15 May 2013 03:46:06 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 15 May 2013 03:46:06 -0700 Received: from [137.202.157.37] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server (TLS) id 14.2.247.3; Wed, 15 May 2013 11:46:04 +0100 Message-ID: <5193676B.7000008@codesourcery.com> Date: Wed, 15 May 2013 10:46:00 -0000 From: mbilal User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: CC: , Subject: Re: [PATCH 1/7] PR gdb/15224 "set history filename" to by immediately converted to absolute path References: <51877A32.1030503@codesourcery.com> <51877A99.4060503@codesourcery.com> <5188AA15.5010904@codesourcery.com> <5188F70A.1030908@codesourcery.com> <518A0B2E.7000706@codesourcery.com> <519366E2.90105@codesourcery.com> In-Reply-To: <519366E2.90105@codesourcery.com> Content-Type: multipart/mixed; boundary="------------030907040006070500090406" X-Virus-Found: No X-SW-Source: 2013-05/txt/msg00511.txt.bz2 --------------030907040006070500090406 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1487 Hi, Please find attached updated patch. On Wednesday, May 08, 2013 8:47 PM Pedro wrote: >Missing space before NULL. That's a lot of casting. We can just refer >to history_filename directly. It'd be very good to have a comment here with the >rationale for this -- there's one in init_history we can reuse. So: Fixed On Wednesday, May 08, 2013 10:25 PM Pedro wrote: >In addition to my previous comments, I realized that this will do the >wrong thing with "set history filename ~/foo". Best use tilde_expand >and gdb_realpath 'set history filename ~/foo' is working because following code is doing same as you described . I have also attached test case for this. if (arg != NULL) { /* Clear trailing whitespace of filename. */ char *ptr = arg + strlen (arg) - 1; while (ptr >= arg && (*ptr == ' ' || *ptr == '\t')) ptr--; *(ptr + 1) = '\0'; val = tilde_expand (arg); } else val = xstrdup (""); if (*(char **) c->var == NULL || strcmp (*(char **) c->var, val) != 0) { xfree (*(char **) c->var); *(char **) c->var = val; option_changed = 1; 2013-05-15 Muhammad Bilal PR gdb/15224 * top.c (set_history_filename): New function. 2013-05-15 Muhammad Bilal PR gdb/15224 * gdb.base/setshow.exp: Test 'set history filename' relative path. Thanks, -Bilal --------------030907040006070500090406 Content-Type: text/plain; charset="UTF-8"; name="1" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="1" Content-length: 4124 ZGlmZiAtLWdpdCBhL2dkYi90b3AuYyBiL2dkYi90b3AuYwppbmRleCA0ODBi NjdlLi40NWI4M2Q3IDEwMDY0NAotLS0gYS9nZGIvdG9wLmMKKysrIGIvZ2Ri L3RvcC5jCkBAIC00OCw2ICs0OCw3IEBACiAjaW5jbHVkZSAiaW50ZXJwcy5o IgogI2luY2x1ZGUgIm9ic2VydmVyLmgiCiAjaW5jbHVkZSAibWFpbnQuaCIK KyNpbmNsdWRlICJmaWxlbmFtZXMuaCIKIAogLyogcmVhZGxpbmUgaW5jbHVk ZSBmaWxlcy4gICovCiAjaW5jbHVkZSAicmVhZGxpbmUvcmVhZGxpbmUuaCIK QEAgLTE2OTMsNiArMTY5NCwxNyBAQCBzaG93X2V4ZWNfZG9uZV9kaXNwbGF5 X3AgKHN0cnVjdCB1aV9maWxlICpmaWxlLCBpbnQgZnJvbV90dHksCiAgICAg ICAgICAgICAgICAgICAgdmFsdWUpOwogfQogCitzdGF0aWMgdm9pZAorc2V0 X2hpc3RvcnlfZmlsZW5hbWUgKGNoYXIgKmFyZ3MsIGludCBmcm9tX3R0eSwg c3RydWN0IGNtZF9saXN0X2VsZW1lbnQgKmMpCit7CisgIC8qIFdlIGluY2x1 ZGUgdGhlIGN1cnJlbnQgZGlyZWN0b3J5IHNvIHRoYXQgaWYgdGhlIHVzZXIg Y2hhbmdlcworICAgICBkaXJlY3RvcmllcyB0aGUgZmlsZSB3cml0dGVuIHdp bGwgYmUgdGhlIHNhbWUgYXMgdGhlIG9uZQorICAgICB0aGF0IHdhcyByZWFk LiAgKi8KKyAgaWYgKCFJU19BQlNPTFVURV9QQVRIIChoaXN0b3J5X2ZpbGVu YW1lKSkKKyAgICBoaXN0b3J5X2ZpbGVuYW1lID0gY29uY2F0IChjdXJyZW50 X2RpcmVjdG9yeSwgIi8iLCBoaXN0b3J5X2ZpbGVuYW1lLAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgKGNoYXIgKikgTlVMTCk7Cit9CisKIC8q ICJzZXQiIGNvbW1hbmQgZm9yIHRoZSBnZGJfZGF0YWRpciBjb25maWd1cmF0 aW9uIHZhcmlhYmxlLiAgKi8KIAogc3RhdGljIHZvaWQKQEAgLTE3NzcsNyAr MTc4OSw3IEBAIHZhcmlhYmxlIFwiSElTVFNJWkVcIiwgb3IgdG8gMjU2IGlm IHRoaXMgdmFyaWFibGUgaXMgbm90IHNldC4iKSwKIFNldCB0aGUgZmlsZW5h bWUgaW4gd2hpY2ggdG8gcmVjb3JkIHRoZSBjb21tYW5kIGhpc3RvcnkiKSwg XygiXAogU2hvdyB0aGUgZmlsZW5hbWUgaW4gd2hpY2ggdG8gcmVjb3JkIHRo ZSBjb21tYW5kIGhpc3RvcnkiKSwgXygiXAogKHRoZSBsaXN0IG9mIHByZXZp b3VzIGNvbW1hbmRzIG9mIHdoaWNoIGEgcmVjb3JkIGlzIGtlcHQpLiIpLAot ICAgICAgICAgICAgICAgICAgICAgICAgICAgTlVMTCwKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgIHNldF9oaXN0b3J5X2ZpbGVuYW1lLAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgc2hvd19oaXN0b3J5X2ZpbGVuYW1lLAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgJnNldGhpc3RsaXN0LCAmc2hv d2hpc3RsaXN0KTsKZGlmZiAtLWdpdCBhL2dkYi90ZXN0c3VpdGUvZ2RiLmJh c2Uvc2V0c2hvdy5leHAgYi9nZGIvdGVzdHN1aXRlL2dkYi5iYXNlL3NldHNo b3cuZXhwCmluZGV4IDZkMjUwYzAuLjUzNDViNGIgMTAwNjQ0Ci0tLSBhL2dk Yi90ZXN0c3VpdGUvZ2RiLmJhc2Uvc2V0c2hvdy5leHAKKysrIGIvZ2RiL3Rl c3RzdWl0ZS9nZGIuYmFzZS9zZXRzaG93LmV4cApAQCAtMTY5LDExICsxNjks MjQgQEAgZ2RiX3Rlc3Rfbm9fb3V0cHV0ICJzZXQgaGVpZ2h0IHVubGltaXRl ZCIKIGdkYl90ZXN0X25vX291dHB1dCAic2V0IGhpc3RvcnkgZXhwYW5zaW9u IG9uIiAic2V0IGhpc3RvcnkgZXhwYW5zaW9uIG9uIiAKICN0ZXN0IHNob3cg aGlzdG9yeSBleHBhbnNpb24gb24KIGdkYl90ZXN0ICJzaG93IGhpc3Rvcnkg ZXhwYW5zaW9uIG9uIiAiSGlzdG9yeSBleHBhbnNpb24gb24gY29tbWFuZCBp bnB1dCBpcyBvbi4qIiAic2hvdyBoaXN0b3J5IGV4cGFuc2lvbiIgCisjZ2V0 IGhvbWUgZGlyZWN0b3J5IHBhdGgKK2dkYl90ZXN0X211bHRpcGxlICJzaG93 IGVudmlyb25tZW50IEhPTUUiICJzaG93IGhvbWUgZGlyZWN0b3J5IiB7Cisg ICAgLXJlICJcbkhPTUUgPSAoLiopLlxuLiokZ2RiX3Byb21wdCAkIiB7Cisg ICAgICAgc2V0IEhPTUUgJGV4cGVjdF9vdXQoMSxzdHJpbmcpICAgIAorICAg IH0KK30KKyN0ZXN0IHNldCBoaXN0b3J5IGZpbGVuYW1lIH4vZm9vYmFyLmJh egorZ2RiX3Rlc3Rfbm9fb3V0cHV0ICJzZXQgaGlzdG9yeSBmaWxlbmFtZSB+ L2Zvb2Jhci5iYXoiIFwKKyAgICAic2V0IGhpc3RvcnkgZmlsZW5hbWUgfi9m b29iYXIuYmF6IiAKKyN0ZXN0IHNob3cgaGlzdG9yeSBmaWxlbmFtZSB+L2Zv b2Jhci5iYXoKK2dkYl90ZXN0ICJzaG93IGhpc3RvcnkgZmlsZW5hbWUiICJU aGUgZmlsZW5hbWUgaW4gd2hpY2ggdG8gcmVjb3JkIHRoZSBjb21tYW5kIGhp c3RvcnkgaXMgXCJbZmlsZSBqb2luICRIT01FIGZvb2Jhci5iYXpdXCIuLioi IFwKKyAgICAic2hvdyBoaXN0b3J5IGZpbGVuYW1lIChbZmlsZSBqb2luICRI T01FIGZvb2Jhci5iYXpdKSIgICAgIAogI3Rlc3Qgc2V0IGhpc3RvcnkgZmls ZW5hbWUgZm9vYmFyLmJhegogZ2RiX3Rlc3Rfbm9fb3V0cHV0ICJzZXQgaGlz dG9yeSBmaWxlbmFtZSBmb29iYXIuYmF6IiBcCiAgICAgInNldCBoaXN0b3J5 IGZpbGVuYW1lIGZvb2Jhci5iYXoiIAogI3Rlc3Qgc2hvdyBoaXN0b3J5IGZp bGVuYW1lIGZvb2Jhci5iYXoKLWdkYl90ZXN0ICJzaG93IGhpc3RvcnkgZmls ZW5hbWUiICJUaGUgZmlsZW5hbWUgaW4gd2hpY2ggdG8gcmVjb3JkIHRoZSBj b21tYW5kIGhpc3RvcnkgaXMgXCJmb29iYXIuYmF6XCIuLioiICAic2hvdyBo aXN0b3J5IGZpbGVuYW1lIChmb29iYXIuYmF6KSIgCitnZGJfdGVzdCAic2hv dyBoaXN0b3J5IGZpbGVuYW1lIiAiVGhlIGZpbGVuYW1lIGluIHdoaWNoIHRv IHJlY29yZCB0aGUgY29tbWFuZCBoaXN0b3J5IGlzIFwiW2ZpbGUgam9pbiBb cHdkXSBmb29iYXIuYmF6XVwiLi4qIiBcCisgICAgInNob3cgaGlzdG9yeSBm aWxlbmFtZSAoW2ZpbGUgam9pbiBbcHdkXSBmb29iYXIuYmF6XSkiIAogI3Rl c3Qgc2V0IGhpc3Rvcnkgc2F2ZSBvbgogZ2RiX3Rlc3Rfbm9fb3V0cHV0ICJz ZXQgaGlzdG9yeSBzYXZlIG9uIiAic2V0IGhpc3Rvcnkgc2F2ZSBvbiIgCiAj dGVzdCBzaG93IGhpc3Rvcnkgc2F2ZSBvbgo= --------------030907040006070500090406--