From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13841 invoked by alias); 14 May 2013 19:24:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13832 invoked by uid 89); 14 May 2013 19:24:36 -0000 X-Spam-SWARE-Status: No, score=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 14 May 2013 19:24:36 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4EJNvVl020315 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 14 May 2013 15:24:33 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4EIU54J027163; Tue, 14 May 2013 14:30:07 -0400 Message-ID: <519282AC.2030707@redhat.com> Date: Tue, 14 May 2013 19:24:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 1/7] New macro THREAD_WITHIN_SINGLE_STEP_RANGE References: <1363006291-13334-1-git-send-email-yao@codesourcery.com> <1363006291-13334-2-git-send-email-yao@codesourcery.com> In-Reply-To: <1363006291-13334-2-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00492.txt.bz2 Hi Yao, Finally I'm replying to this series. As I said before, I ended up working on the code, and I'll post a v3 next. I'm still replying to the individual patches, to point out some of the issues I found. On 03/11/2013 12:51 PM, Yao Qi wrote: > This patch moves code into a macro, which will be used in my > following patches. I agree with the idea. > 2013-03-11 Yao Qi > > * gdbthread.h (THREAD_WITHIN_SINGLE_STEP_RANGE): New macro. > * infrun.c (handle_inferior_event): Use it. However, the gdbserver patch does: +/* Return true if THREAD is in range stepping. PC is the value of pc + of THREAD. */ + +int +thread_in_range_stepping_p (struct thread_info *thread, CORE_ADDR pc) +{ + return (pc >= thread->start && pc < thread->end); } If we have code doing the exact same at the same conceptual level in both gdb and gdbserver, I'd rather it is similar. -- Pedro Alves