Re: [RFA] gdbserver/lynx178: spurious SIG61 signal when resuming inferior.

Joel Brobecker
2013-05-17T06:57:43Z

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

> Nit, the comments above talk about null_ptid, while the code is
> really checking for minus_one_ptid (wildcard).

Argh! Going through the emails, I noticed I forgot about this comment
before committing. Sorry about that...

Fixed thusly.

gdb/gdbserver/ChangeLog:

* lynx-low.c (lynx_resume): Fix null_ptid/minus_one_ptid
confusion in comment.

Tested by rebuilding the lynx178 gdbserver. Checked in.

--
Joel

[-- Attachment #2: 0001-gdbserver-lynx178-Fix-null_ptid-vs-minus_one_ptid-co.patch --]
[-- Type: text/x-diff, Size: 2507 bytes --]

From 415cbe11443c18ee01256eb6d529005a6c6fa7e2 Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Fri, 17 May 2013 02:49:40 -0400
Subject: [PATCH] [gdbserver/lynx178]: Fix null_ptid -vs- minus_one_ptid confusion in comment

gdb/gdbserver/ChangeLog:

* lynx-low.c (lynx_resume): Fix null_ptid/minus_one_ptid
confusion in comment.
---
gdb/gdbserver/ChangeLog | 5 +++++
gdb/gdbserver/lynx-low.c | 10 +++++-----
2 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index 5cc2c25..bc2ba38 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,5 +1,10 @@
2013-05-17 Joel Brobecker <brobecker@adacore.com>

+ * lynx-low.c (lynx_resume): Fix null_ptid/minus_one_ptid
+ confusion in comment.
+
+2013-05-17 Joel Brobecker <brobecker@adacore.com>
+
* lynx-low.c (struct process_info_private): New type.
(lynx_add_process): New function.
(lynx_create_inferior, lynx_attach): Replace calls to
diff --git a/gdb/gdbserver/lynx-low.c b/gdb/gdbserver/lynx-low.c
index b4cb5d2..3dbffa5 100644
--- a/gdb/gdbserver/lynx-low.c
+++ b/gdb/gdbserver/lynx-low.c
@@ -284,7 +284,7 @@ lynx_resume (struct thread_resume *resume_info, size_t n)
? PTRACE_SINGLESTEP : PTRACE_CONT);
const int signal = resume_info[0].sig;

- /* If given a null_ptid, then try using the current_process'
+ /* If given a minus_one_ptid, then try using the current_process'
private->last_wait_event_ptid. On most LynxOS versions,
using any of the process' thread works well enough, but
LynxOS 178 is a little more sensitive, and triggers some
@@ -293,10 +293,10 @@ lynx_resume (struct thread_resume *resume_info, size_t n)
if (ptid_equal (ptid, minus_one_ptid))
ptid = current_process()->private->last_wait_event_ptid;

- /* The ptid might still be NULL; this can happen between the moment
- we create the inferior or attach to a process, and the moment
- we resume its execution for the first time. It is fine to
- use the current_inferior's ptid in those cases. */
+ /* The ptid might still be minus_one_ptid; this can happen between
+ the moment we create the inferior or attach to a process, and
+ the moment we resume its execution for the first time. It is
+ fine to use the current_inferior's ptid in those cases. */
if (ptid_equal (ptid, minus_one_ptid))
ptid = thread_to_gdb_id (current_inferior);

--
1.7.0.4