From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5306 invoked by alias); 13 May 2013 02:33:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5293 invoked by uid 89); 13 May 2013 02:33:40 -0000 X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 13 May 2013 02:33:39 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1Ubia1-0003lK-AL from Yao_Qi@mentor.com ; Sun, 12 May 2013 19:33:37 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Sun, 12 May 2013 19:33:37 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Sun, 12 May 2013 19:33:36 -0700 Message-ID: <51905107.5090107@codesourcery.com> Date: Mon, 13 May 2013 02:33:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Tom Tromey CC: Subject: Re: [PATCH 14/40] fix two buglets in breakpoint.c References: <9950c2e4c9891c1b716d6c6d32107ddd7e97c5a5.1368124285.git.tromey@redhat.com> In-Reply-To: <9950c2e4c9891c1b716d6c6d32107ddd7e97c5a5.1368124285.git.tromey@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-05/txt/msg00412.txt.bz2 On 05/10/2013 02:51 AM, Tom Tromey wrote: > @@ -5814,7 +5814,10 @@ output_thread_groups (struct ui_out *uiout, > /* For backward compatibility, don't display inferiors in CLI unless > there are several. Always display them for MI. */ > if (!is_mi && mi_only) > - return; > + { > + do_cleanups (back_to); > + return; > + } Tom, A nit here, we may call 'make_cleanup_ui_out_list_begin_end' after this condition checking, so we don't need 'do_cleanups' here. -- Yao (齐尧)