From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24790 invoked by alias); 26 Sep 2017 21:09:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24723 invoked by uid 89); 26 Sep 2017 21:09:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=H*r:sk:c-73-23, H*RU:sk:c-73-23, Hx-spam-relays-external:sk:c-73-23 X-HELO: mail.baldwin.cx Received: from bigwig.baldwin.cx (HELO mail.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Sep 2017 21:09:32 +0000 Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id 8894B10AFAA; Tue, 26 Sep 2017 17:09:30 -0400 (EDT) From: John Baldwin To: gdb-patches@sourceware.org Cc: Rainer Orth Subject: Re: Remove ioctl-based procfs support on Solaris Date: Tue, 26 Sep 2017 21:09:00 -0000 Message-ID: <5190367.sVyILAhGg6@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00816.txt.bz2 On Tuesday, September 26, 2017 02:23:35 PM Rainer Orth wrote: > This is the previously mentioned patch to get rid of > unstructured/ioctl-based procfs support in procfs.c. Given that support > for structured procfs was introduced in Solaris 2.6 back in 1997 and > we're just removing support for Solaris < 10, there's no point in > carrying that baggage (and tons of support for IRIX and OSF/11 as well) > around any longer. > > Most of the patch should be straightforward (removing support for > !NEW_PROC_API, non-Solaris OSes and pre-Solaris 10 quirks). > > Only a few points need explanations: > > * was already included unconditionally in most places, > so there's no need to have guards in a few remaining ones. > > * configure.host already obsoletes i?86-*-sysv4.2, i?86-*-sysv5, so > NEW_PROC_API detection for those in configure.ac can go. > > * I'm still including with #define _STRUCTURED_PROC 1. > Theoretically, it would be better to include on Solaris > (which includes that define), but that breaks the build over > vs. gdb's "procfs.h", and doesn't exist on Linux. > > * I've regenerated syscall_table[] in proc-events.c with a small script > from Solaris 10, 11.3, 11.4 , so there should be no > traces of older Solaris versions and other OSes left. > > * prsysent_t and DYNAMIC_SYSCALLS was only used for AIX 5, but AIX > doesn't use procfs.c any longer, so all related code can go. > > The patch was generated with diff -w so one can easier see changes > without being distracted by simple reindentations. > > So far, it has only been compiled and smoke-tested on > amd64-pc-solaris2.1[01], sparcv9-sun-solaris2.1[01], and > x86_64-pc-linux-gnu. Certainly needs more testing (Solaris 11.3 > vs. 11.4, 32-bit gdb, testsuite once I've figured out what's wrong on > Solaris 10 etc.), but it's enough to get a first impression how much > cleanup is possible here. FYI, bsd-kvm.c uses HAVE_SYS_USER_H and also uses _KMEMUSER (which your ChangeLog mentions, but I didn't see it removed in the configure.ac diff) bsd-kvm.c also uses but it uses it unconditionally. -- John Baldwin