From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24707 invoked by alias); 10 May 2013 17:20:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24698 invoked by uid 89); 10 May 2013 17:20:21 -0000 X-Spam-SWARE-Status: No, score=-8.4 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 10 May 2013 17:20:20 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4AHKHwb002763 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 10 May 2013 13:20:17 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4AHKFOd028526; Fri, 10 May 2013 13:20:17 -0400 Message-ID: <518D2C4F.8070102@redhat.com> Date: Fri, 10 May 2013 17:20:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Philippe Waroquiers CC: gdb-patches@sourceware.org Subject: Re: RFA: fix gdb_assert caused by 'catch signal ...' and fork References: <1368136582.30058.7.camel@soleil> In-Reply-To: <1368136582.30058.7.camel@soleil> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00395.txt.bz2 Hi Philippe, (Please mark newer posts/revisions of patches in new threads with v2, v3, etc. in the subject line.) > Index: gdb/testsuite/gdb.base/catch-signal-fork.c > =================================================================== > RCS file: gdb/testsuite/gdb.base/catch-signal-fork.c > diff -N gdb/testsuite/gdb.base/catch-signal-fork.c > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ gdb/testsuite/gdb.base/catch-signal-fork.c 9 May 2013 21:46:36 -0000 > @@ -0,0 +1,58 @@ > +/* This testcase is part of GDB, the GNU debugger. > + > + Copyright 2013-2013 Free Software Foundation, Inc. Write only "2013" when we only have a single year. But, if the file is based on another existing file, we should preserve the existing file's copyright years in the new file. > +int > +main () > +{ > + int i; > + signal (SIGHUP, handle); > + > + raise (SIGHUP); /* first HUP */ > + > + signal (SIGCHLD, handle); > + for (i = 0; i < 3; i++) /* fork loop */ > + { > + switch (fork()) > + { > + case -1: > + perror ("fork"); > + exit (1); > + case 0: > + exit (0); > + } > + (void) wait(NULL); Missing space before parens. (do you really need the cast?) > Index: gdb/testsuite/gdb.base/catch-signal-fork.exp > =================================================================== > RCS file: gdb/testsuite/gdb.base/catch-signal-fork.exp > diff -N gdb/testsuite/gdb.base/catch-signal-fork.exp > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ gdb/testsuite/gdb.base/catch-signal-fork.exp 9 May 2013 21:46:36 -0000 > @@ -0,0 +1,43 @@ > +# Copyright 2013-2013 Free Software Foundation, Inc. 2013-2013 again. -- Pedro Alves