From: Freddie Chopin <freddie_chopin@op.pl>
To: gdb-patches@sourceware.org
Subject: Fix for bug 15414 - Build fails with mingw32-w64 GCC-4.8.0
Date: Thu, 09 May 2013 17:22:00 -0000 [thread overview]
Message-ID: <518BDB4F.2070509@op.pl> (raw)
[-- Attachment #1: Type: text/plain, Size: 109 bytes --]
http://sourceware.org/bugzilla/show_bug.cgi?id=15414
The idea of change comes from Tom Tromey
Regards,
FCh
[-- Attachment #2: changelog --]
[-- Type: text/plain, Size: 271 bytes --]
* configure.ac: Fix PR gdb/15414
Fix FTBFS on mingw32 GCC 4.8.0 - -Wformat-* cannot be used when
-Wno-format is also present - this causes a warning in GCC 4.8.0 (does
not happen in earlier versions), which is treated as error.
* sim/common/acinclude.m4: Likewise
[-- Attachment #3: configure.patch --]
[-- Type: text/x-patch, Size: 1628 bytes --]
diff --git a/gdb/configure.ac b/gdb/configure.ac
index bb7fbdd..7c2080c 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -1926,7 +1926,7 @@ fi
# NOTE: If you change this list, remember to update
# gdb/doc/gdbint.texinfo.
build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \
--Wformat-nonliteral -Wpointer-sign \
+-Wpointer-sign \
-Wno-unused -Wunused-value -Wunused-function \
-Wno-switch -Wno-char-subscripts -Wmissing-prototypes \
-Wdeclaration-after-statement -Wempty-body"
@@ -1935,6 +1935,7 @@ build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \
# GCC versions complain about %I64.
case "${host}" in
*-*-mingw32*) build_warnings="$build_warnings -Wno-format" ;;
+ *) build_warnings="$build_warnings -Wformat-nonliteral" ;;
esac
AC_ARG_ENABLE(build-warnings,
diff --git a/sim/common/acinclude.m4 b/sim/common/acinclude.m4
index 73191f2..583f7c3 100644
--- a/sim/common/acinclude.m4
+++ b/sim/common/acinclude.m4
@@ -872,7 +872,7 @@ fi
# NOTE: If you change this list, remember to update
# gdb/doc/gdbint.texinfo.
build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \
--Wformat-nonliteral -Wno-pointer-sign \
+-Wno-pointer-sign \
-Wno-unused -Wunused-value -Wunused-function \
-Wno-switch -Wno-char-subscripts -Wmissing-prototypes"
@@ -880,6 +880,7 @@ build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \
# GCC versions complain about %I64.
case "${host}" in
*-*-mingw32*) build_warnings="$build_warnings -Wno-format" ;;
+ *) build_warnings="$build_warnings -Wformat-nonliteral" ;;
esac
AC_ARG_ENABLE(build-warnings,
next reply other threads:[~2013-05-09 17:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 17:22 Freddie Chopin [this message]
2013-05-09 19:43 ` Mike Frysinger
2013-05-10 16:09 ` Tom Tromey
2013-05-10 17:53 ` Freddie Chopin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518BDB4F.2070509@op.pl \
--to=freddie_chopin@op.pl \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox