From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7040 invoked by alias); 9 May 2013 12:05:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6980 invoked by uid 89); 9 May 2013 12:05:30 -0000 X-Spam-SWARE-Status: No, score=-8.3 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 09 May 2013 12:05:29 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r49C5QGI002301 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 9 May 2013 08:05:26 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r49C5ND4022695; Thu, 9 May 2013 08:05:25 -0400 Message-ID: <518B9103.3060005@redhat.com> Date: Thu, 09 May 2013 12:05:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: mbilal CC: hafiz_abid@mentor.com, gdb-patches@sourceware.org, jan.kratochvil@redhat.com Subject: Re: [PATCH 4/7] PR gdb/15224 should "set history save on" by default References: <51877A32.1030503@codesourcery.com> <51877A99.4060503@codesourcery.com> <51877B42.7@codesourcery.com> <51877BC6.6080007@codesourcery.com> <518A0B95.7090905@codesourcery.com> <518B8492.90606@codesourcery.com> In-Reply-To: <518B8492.90606@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00308.txt.bz2 On 05/09/2013 12:12 PM, mbilal wrote: > On Wednesday, May 08, 2013 10:14 PM pedro Alves wrote: > >>> - set INTERNAL_GDBFLAGS "-nw -nx -data-directory $BUILD_DATA_DIRECTORY" >>> + set INTERNAL_GDBFLAGS "-nw -nx -ex set\\ history\\ save\\ off -data-directory $BUILD_DATA_DIRECTORY" > >>spurious space? ------^^ > > Fixed. BTW, I think: set INTERNAL_GDBFLAGS "-nw -nx -ex \"set history save off\" -data-directory $BUILD_DATA_DIRECTORY" would be easier to read (and write). >>> +#We are always disable history saving on testsuite >>> #test set history save >>> -gdb_test_no_output "set history save" "set history save" >>> +#gdb_test_no_output "set history save" "set history save" >>> #test set history size > >>I don't understand this. Why disable the test? > > We are disabling the history saving on all testsuit, if we run the above > testsuit then history saving becomes enable that will also writes the history > command on .gdb_history file. That's why I disabled this test case. So that's a preexisting bug, that triggers even if GDB's default isn't changed, right? Let's fix it first, before the default is changed, in its own patch. Please send it as a new thread (i.e., not in reply to this thread, in a message that includes a self-contained description of the rationale for the change, and a concise Subject:. I suggest perusing these guidelines that although written for the Linux kernel, can be transcribed to lots of other projects as well: Instead of disabling the test completely, I suggest re-disabling history saving immediately afterwards: gdb_test_no_output "set history save" "set history save" +gdb_test_no_output "set history save off" "set history save off" -- Pedro Alves