From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9984 invoked by alias); 8 May 2013 17:25:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9974 invoked by uid 89); 8 May 2013 17:25:14 -0000 X-Spam-SWARE-Status: No, score=-8.4 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 08 May 2013 17:25:14 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r48HP9gM026506 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 8 May 2013 13:25:12 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r48HP28X021738; Wed, 8 May 2013 13:25:04 -0400 Message-ID: <518A8A6E.30709@redhat.com> Date: Wed, 08 May 2013 17:25:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: mbilal CC: gdb-patches@sourceware.org, jan.kratochvil@redhat.com Subject: Re: [PATCH 1/7] PR gdb/15224 "set history filename" to by immediately converted to absolute path References: <51877A32.1030503@codesourcery.com> <51877A99.4060503@codesourcery.com> <5188AA15.5010904@codesourcery.com> <5188F70A.1030908@codesourcery.com> <518A736C.8070009@redhat.com> In-Reply-To: <518A736C.8070009@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00292.txt.bz2 On 05/08/2013 04:46 PM, Pedro Alves wrote: >> +static void >> +set_history_filename (char *args, int from_tty, struct cmd_list_element *c) >> +{ >> + if (!IS_ABSOLUTE_PATH (*(char **) c->var)) >> + *(char **) c->var = concat (current_directory, "/", *(char **) c->var, >> + (char *)NULL); >> +} In addition to my previous comments, I realized that this will do the wrong thing with "set history filename ~/foo". Best use tilde_expand and gdb_realpath. -- Pedro Alves