From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 530 invoked by alias); 8 May 2013 17:14:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 513 invoked by uid 89); 8 May 2013 17:14:49 -0000 X-Spam-SWARE-Status: No, score=-8.4 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 08 May 2013 17:14:48 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r48HEjdo022834 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 8 May 2013 13:14:45 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r48HEhno030854; Wed, 8 May 2013 13:14:44 -0400 Message-ID: <518A8802.9010406@redhat.com> Date: Wed, 08 May 2013 17:14:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: mbilal CC: gdb-patches@sourceware.org, jan.kratochvil@redhat.com Subject: Re: [PATCH 4/7] PR gdb/15224 should "set history save on" by default References: <51877A32.1030503@codesourcery.com> <51877A99.4060503@codesourcery.com> <51877B42.7@codesourcery.com> <51877BC6.6080007@codesourcery.com> <51877C29.80409@codesourcery.com> In-Reply-To: <51877C29.80409@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00290.txt.bz2 On 05/06/2013 10:47 AM, mbilal wrote: > On Wednesday, April 03, 2013 7:30 PM Jan Kratochvil wrote: > >> (4) Modify GDB testsuite to always disable history saving. > > patch for this. > > Index: lib/gdb.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v > retrieving revision 1.230 > diff -u -p -r1.230 gdb.exp > --- lib/gdb.exp 15 Apr 2013 20:37:37 -0000 1.230 > +++ lib/gdb.exp 6 May 2013 07:01:55 -0000 > @@ -58,7 +58,7 @@ set BUILD_DATA_DIRECTORY "[pwd]/../data- > # INTERNAL_GDBFLAGS contains flags that the testsuite requires. > global INTERNAL_GDBFLAGS > if ![info exists INTERNAL_GDBFLAGS] { > - set INTERNAL_GDBFLAGS "-nw -nx -data-directory $BUILD_DATA_DIRECTORY" > + set INTERNAL_GDBFLAGS "-nw -nx -ex set\\ history\\ save\\ off -data-directory $BUILD_DATA_DIRECTORY" spurious space? ------^^ > } > > # The variable gdb_prompt is a regexp which matches the gdb prompt. > Index: gdb.base/default.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/default.exp,v > retrieving revision 1.64 > diff -u -p -r1.64 default.exp > --- gdb.base/default.exp 15 Apr 2013 18:09:02 -0000 1.64 > +++ gdb.base/default.exp 6 May 2013 07:02:53 -0000 > @@ -521,8 +521,9 @@ gdb_test "set height" "Argument required > gdb_test_no_output "set history expansion" "set history expansion" > #test set history filename > gdb_test "set history filename" "Argument required .filename to set it to.*" "set history filename" > +#We are always disable history saving on testsuite > #test set history save > -gdb_test_no_output "set history save" "set history save" > +#gdb_test_no_output "set history save" "set history save" > #test set history size I don't understand this. Why disable the test? > gdb_test "set history size" "Argument required .integer to set it to.*" "set history size" > #test set history > @@ -644,7 +645,7 @@ gdb_test "show history expansion" "Histo > #test show history filename > gdb_test "show history filename" "The filename in which to record the command history is.*.gdb_history.*" "show history filename" > #test show history save > -gdb_test "show history save" "Saving of the history record on exit is on." "show history save" > +gdb_test "show history save" "Saving of the history record on exit is off." "show history save" > #test show history size > gdb_test "show history size" "The size of the command history is.*" "show history size" > #test show history > Index: gdb.base/setshow.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/setshow.exp,v > retrieving revision 1.30 > diff -u -p -r1.30 setshow.exp > --- gdb.base/setshow.exp 24 Apr 2013 14:29:17 -0000 1.30 > +++ gdb.base/setshow.exp 6 May 2013 07:08:29 -0000 > @@ -174,10 +174,11 @@ gdb_test_no_output "set history filename > "set history filename foobar.baz" > #test show history filename foobar.baz > gdb_test "show history filename" "The filename in which to record the command history is \"foobar.baz\"..*" "show history filename (foobar.baz)" > +#We are always disable history saving on testsuite > #test set history save on > -gdb_test_no_output "set history save on" "set history save on" > +#gdb_test_no_output "set history save on" "set history save on" > #test show history save on > -gdb_test "show history save" "Saving of the history record on exit is on..*" "show history save (on)" > +gdb_test "show history save" "Saving of the history record on exit is off..*" "show history save (off)" > #test set history size 100 > gdb_test_no_output "set history size 100" "set history size 100" > #test show history size 100 Likewise. -- Pedro Alves