From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31804 invoked by alias); 8 May 2013 16:24:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31793 invoked by uid 89); 8 May 2013 16:24:28 -0000 X-Spam-SWARE-Status: No, score=-8.4 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 08 May 2013 16:24:27 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r48GOP2l026176 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 8 May 2013 12:24:25 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r48GOMDj013992; Wed, 8 May 2013 12:24:24 -0400 Message-ID: <518A7C36.2070701@redhat.com> Date: Wed, 08 May 2013 16:24:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: mbilal CC: gdb-patches@sourceware.org, jan.kratochvil@redhat.com Subject: Re: [PATCH 3/7] PR gdb/15224 should "set history save on" by default References: <51877A32.1030503@codesourcery.com> <51877A99.4060503@codesourcery.com> <51877B42.7@codesourcery.com> In-Reply-To: <51877B42.7@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00285.txt.bz2 On 05/06/2013 10:43 AM, mbilal wrote: > On Wednesday, April 03, 2013 7:30 PM Jan Kratochvil wrote: > >> (3) Fix currently incorrectly touched history file even if no commands get > > here is patch Missing ChangeLog entry. > > Index: top.c > =================================================================== > RCS file: /cvs/src/src/gdb/top.c,v > retrieving revision 1.235 > diff -u -p -r1.235 top.c > --- top.c 17 Apr 2013 01:02:02 -0000 1.235 > +++ top.c 6 May 2013 06:16:04 -0000 > @@ -1430,7 +1430,8 @@ quit_force (char *args, int from_tty) > /* Save the history information if it is appropriate to do so. */ > DO_TRY > { > - if (write_history_p && history_filename) > + if (write_history_p && history_filename > + && input_from_terminal_p()) Missing space before parens. > write_history (history_filename); > } > DO_PRINT_EX; > > > > I have tested It'd be great if we had that in our testsuite. -- Pedro Alves