From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7330 invoked by alias); 8 May 2013 08:24:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7321 invoked by uid 89); 8 May 2013 08:24:13 -0000 X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 08 May 2013 08:24:12 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UZzfX-0003sv-5A from Muhammad_Bilal@mentor.com ; Wed, 08 May 2013 01:24:11 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 8 May 2013 01:24:11 -0700 Received: from [137.202.157.37] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server (TLS) id 14.2.247.3; Wed, 8 May 2013 09:24:08 +0100 Message-ID: <518A0BA8.9000703@codesourcery.com> Date: Wed, 08 May 2013 08:24:00 -0000 From: mbilal User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: , , Subject: Re: [PATCH 5/7] PR gdb/15224 should "set history save on" by default References: <51877A32.1030503@codesourcery.com> <51877A99.4060503@codesourcery.com> <51877B42.7@codesourcery.com> <51877BC6.6080007@codesourcery.com> <51877C76.2000509@codesourcery.com> In-Reply-To: <51877C76.2000509@codesourcery.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00277.txt.bz2 On 05/06/2013 02:48 PM, mbilal wrote: > On Wednesday, April 03, 2013 7:30 PM Jan Kratochvil wrote: > > > (6) Change the default set history filename to ~/.gdb_history. > > patch is here. > > Index: top.c > =================================================================== > RCS file: /cvs/src/src/gdb/top.c,v > retrieving revision 1.235 > diff -u -p -r1.235 top.c > --- top.c 17 Apr 2013 01:02:02 -0000 1.235 > +++ top.c 6 May 2013 07:17:13 -0000 > @@ -1616,7 +1616,8 @@ void > init_history (void) > { > char *tmpenv; > - > + char *homedir; > + homedir = getenv ("HOME"); > tmpenv = getenv ("HISTSIZE"); > if (tmpenv) > { > @@ -1651,10 +1652,10 @@ init_history (void) > that was read. */ > #ifdef __MSDOS__ > /* No leading dots in file names are allowed on MSDOS. */ > - history_filename = concat (current_directory, "/_gdb_history", > + history_filename = concat (homedir, "/_gdb_history", > (char *)NULL); > #else > - history_filename = concat (current_directory, "/.gdb_history", > + history_filename = concat (homedir, "/.gdb_history", > (char *)NULL); > #endif > } > Index: testsuite/gdb.base/default.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/default.exp,v > retrieving revision 1.64 > diff -u -p -r1.64 default.exp > --- testsuite/gdb.base/default.exp 15 Apr 2013 18:09:02 -0000 1.64 > +++ testsuite/gdb.base/default.exp 6 May 2013 07:52:42 -0000 > @@ -642,7 +642,8 @@ gdb_test "show height" "Number of lines > #test show history expansion > gdb_test "show history expansion" "History expansion on command input > is o\[a-z\]*.*" "show history expansion" > #test show history filename > -gdb_test "show history filename" "The filename in which to record the > command history is.*.gdb_history.*" "show history filename" > +gdb_test "show history filename" "The filename in which to record the > command history is .$env(HOME).*.gdb_history.*." \ > + "show history filename .$env(HOME).*.gdb_history." > #test show history save > gdb_test "show history save" "Saving of the history record on exit is > on." "show history save" > #test show history size > > > Thanks, > -Bilal ping