From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5946 invoked by alias); 8 May 2013 08:23:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5936 invoked by uid 89); 8 May 2013 08:23:54 -0000 X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 08 May 2013 08:23:53 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UZzfE-0003pn-BM from Muhammad_Bilal@mentor.com ; Wed, 08 May 2013 01:23:52 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 8 May 2013 01:23:52 -0700 Received: from [137.202.157.37] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server (TLS) id 14.2.247.3; Wed, 8 May 2013 09:23:50 +0100 Message-ID: <518A0B95.7090905@codesourcery.com> Date: Wed, 08 May 2013 08:23:00 -0000 From: mbilal User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: , , Subject: Re: [PATCH 4/7] PR gdb/15224 should "set history save on" by default References: <51877A32.1030503@codesourcery.com> <51877A99.4060503@codesourcery.com> <51877B42.7@codesourcery.com> <51877BC6.6080007@codesourcery.com> In-Reply-To: <51877BC6.6080007@codesourcery.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00275.txt.bz2 On 05/06/2013 02:45 PM, mbilal wrote: > On Wednesday, April 03, 2013 7:30 PM Jan Kratochvil wrote: > > > (4) Modify GDB testsuite to always disable history saving. > > patch for this. > > Index: lib/gdb.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/lib/gdb.exp,v > retrieving revision 1.230 > diff -u -p -r1.230 gdb.exp > --- lib/gdb.exp 15 Apr 2013 20:37:37 -0000 1.230 > +++ lib/gdb.exp 6 May 2013 07:01:55 -0000 > @@ -58,7 +58,7 @@ set BUILD_DATA_DIRECTORY "[pwd]/../data- > # INTERNAL_GDBFLAGS contains flags that the testsuite requires. > global INTERNAL_GDBFLAGS > if ![info exists INTERNAL_GDBFLAGS] { > - set INTERNAL_GDBFLAGS "-nw -nx -data-directory > $BUILD_DATA_DIRECTORY" > + set INTERNAL_GDBFLAGS "-nw -nx -ex set\\ history\\ save\\ off > -data-directory $BUILD_DATA_DIRECTORY" > } > > # The variable gdb_prompt is a regexp which matches the gdb prompt. > Index: gdb.base/default.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/default.exp,v > retrieving revision 1.64 > diff -u -p -r1.64 default.exp > --- gdb.base/default.exp 15 Apr 2013 18:09:02 -0000 1.64 > +++ gdb.base/default.exp 6 May 2013 07:02:53 -0000 > @@ -521,8 +521,9 @@ gdb_test "set height" "Argument required > gdb_test_no_output "set history expansion" "set history expansion" > #test set history filename > gdb_test "set history filename" "Argument required .filename to set > it to.*" "set history filename" > +#We are always disable history saving on testsuite > #test set history save > -gdb_test_no_output "set history save" "set history save" > +#gdb_test_no_output "set history save" "set history save" > #test set history size > gdb_test "set history size" "Argument required .integer to set it > to.*" "set history size" > #test set history > @@ -644,7 +645,7 @@ gdb_test "show history expansion" "Histo > #test show history filename > gdb_test "show history filename" "The filename in which to record the > command history is.*.gdb_history.*" "show history filename" > #test show history save > -gdb_test "show history save" "Saving of the history record on exit is > on." "show history save" > +gdb_test "show history save" "Saving of the history record on exit is > off." "show history save" > #test show history size > gdb_test "show history size" "The size of the command history is.*" > "show history size" > #test show history > Index: gdb.base/setshow.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/setshow.exp,v > retrieving revision 1.30 > diff -u -p -r1.30 setshow.exp > --- gdb.base/setshow.exp 24 Apr 2013 14:29:17 -0000 1.30 > +++ gdb.base/setshow.exp 6 May 2013 07:08:29 -0000 > @@ -174,10 +174,11 @@ gdb_test_no_output "set history filename > "set history filename foobar.baz" > #test show history filename foobar.baz > gdb_test "show history filename" "The filename in which to record the > command history is \"foobar.baz\"..*" "show history filename > (foobar.baz)" > +#We are always disable history saving on testsuite > #test set history save on > -gdb_test_no_output "set history save on" "set history save on" > +#gdb_test_no_output "set history save on" "set history save on" > #test show history save on > -gdb_test "show history save" "Saving of the history record on exit is > on..*" "show history save (on)" > +gdb_test "show history save" "Saving of the history record on exit is > off..*" "show history save (off)" > #test set history size 100 > gdb_test_no_output "set history size 100" "set history size 100" > #test show history size 100 > > > > > Thanks, > -Bilal ping?