From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-101268-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4675 invoked by alias); 8 May 2013 08:22:44 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 4643 invoked by uid 89); 8 May 2013 08:22:43 -0000
X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 08 May 2013 08:22:42 +0000
Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58])	by relay1.mentorg.com with esmtp 	id 1UZze5-0003kc-7d from Muhammad_Bilal@mentor.com ; Wed, 08 May 2013 01:22:41 -0700
Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675);	 Wed, 8 May 2013 01:22:41 -0700
Received: from [137.202.157.37] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server (TLS) id 14.2.247.3; Wed, 8 May 2013 09:22:39 +0100
Message-ID: <518A0B4E.50808@codesourcery.com>
Date: Wed, 08 May 2013 08:22:00 -0000
From: mbilal <mbilal@codesourcery.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: <palves@redhat.com>, <gdb-patches@sourceware.org>,	<jan.kratochvil@redhat.com>
Subject: Re: [PATCH 2/7] PR gdb/15224  fix for Unify interactivity tests to use input_from_terminal_p
References: <51877A32.1030503@codesourcery.com> <51877A99.4060503@codesourcery.com> <5188AA15.5010904@codesourcery.com> <5188AC27.1050407@codesourcery.com> <5188AC99.6060504@codesourcery.com>
In-Reply-To: <5188AC99.6060504@codesourcery.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2013-05/txt/msg00274.txt.bz2

On 05/07/2013 12:26 PM, mbilal wrote:
> Here is a updated patch for fix for Unify interactivity tests to use 
> input_from_terminal_p:
> On Monday, May 06, 2013 4:26 PM Pedro Alves wrote:
>
>> Please do this in  the command's set handler rather than
> >hacking in the the set/show machinery.
>
> Thanks Pedro for correct guide line
>
> Index: event-top.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/event-top.c,v
> retrieving revision 1.94
> diff -u -p -r1.94 event-top.c
> --- event-top.c    21 Mar 2013 17:37:29 -0000    1.94
> +++ event-top.c    7 May 2013 07:03:33 -0000
> @@ -604,7 +604,8 @@ command_line_handler (char *rl)
>
>    /* Add line to history if appropriate.  */
>    if (instream == stdin
> -      && ISATTY (stdin) && *linebuffer)
> +      && ISATTY (stdin) && *linebuffer
> +      && input_from_terminal_p())
>      add_history (linebuffer);
>
>    /* Note: lines consisting solely of comments are added to the command
>
>
>
>
> And please help me to review other patchesas well.
>
>
> Thanks,
> -Bilal
ping?