From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25670 invoked by alias); 7 May 2013 16:16:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25657 invoked by uid 89); 7 May 2013 16:16:55 -0000 X-Spam-SWARE-Status: No, score=-8.3 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS,TW_XS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 07 May 2013 16:16:55 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r47GGrQT018112 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 7 May 2013 12:16:54 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r47GGosI024855; Tue, 7 May 2013 12:16:51 -0400 Message-ID: <518928F2.4080507@redhat.com> Date: Tue, 07 May 2013 16:16:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Sergio Durigan Junior CC: GDB Patches , "Dr. David Alan Gilbert" Subject: Re: [PATCH] Fix for PR 15413 (segfault when completing "condition" for pending bp) References: <5187ED3A.8000108@redhat.com> <51881BCD.7070009@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00243.txt.bz2 On 05/07/2013 04:39 AM, Sergio Durigan Junior wrote: > - for (loc = b->loc; loc; loc = loc->next) > - { > - char location[50]; > - > - if (single) > - xsnprintf (location, sizeof (location), "%d", b->number); > - else > - xsnprintf (location, sizeof (location), "%d.%d", b->number, > - count); > + { > + char location[50]; This is no longer a location. So s/location/number/g. > > +# Complete the condition (PR 15413). > +# This test must come right after we set the first pending breakpoint, and > +# before we set any other breakpoint, since we are testing if the "condition" > +# command can properly complete its argument. The PR only fails if there > +# is only one pending breakpoint set (without anything else). This last sentence isn't right. You only need a pending breakpoint to trigger the crash, it doesn't matter how many breakpoints you have. > +gdb_test "complete condition " "condition 1" OK with these fixed, mainline and 7.6. Thanks, -- Pedro Alves