Re: [PATCH 7/7] PR gdb/15224 should "set history save on" by default

Abid, Hafiz
2013-05-07T10:17:52Z

On 06/05/13 10:50:59, mbilal wrote:
> Here is doc and news entry.
>
> Index: doc/gdb.texinfo
> ===================================================================
> RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
> retrieving revision 1.1084
> diff -u -p -r1.1084 gdb.texinfo
> --- doc/gdb.texinfo 29 Apr 2013 17:32:43 -0000 1.1084
> +++ doc/gdb.texinfo 6 May 2013 09:28:27 -0000
> @@ -21286,7 +21286,7 @@ is not set.
> @item set history save
> @itemx set history save on
> Record command history in a file, whose name may be specified with
> the
> -@code{set history filename} command. By default, this option is
> disabled.
> +@code{set history filename} command. By default, this option is
> enabled.
>
> @item set history save off
> Stop recording command history in a file.
> Index: doc/ChangeLog
> ===================================================================
> RCS file: /cvs/src/src/gdb/doc/ChangeLog,v
> retrieving revision 1.1452
> diff -u -p -r1.1452 ChangeLog
> --- doc/ChangeLog 29 Apr 2013 17:32:43 -0000 1.1452
> +++ doc/ChangeLog 6 May 2013 09:28:56 -0000
> @@ -1,3 +1,8 @@
> +2013-05-06 Muhammad Bilal <mbilal@codesourcery.com>
> +
> + PR gdb/15224:
> + * gdb.texinfo (Command history): Set history save enabled.
This is not very clear. May be you can use something like "Mention that
'set history save' is 'on' by default."

> +
> 2013-04-29 Tom Tromey <tromey@redhat.com>
>
> PR python/14204:
> Index: NEWS
> ===================================================================
> RCS file: /cvs/src/src/gdb/NEWS,v
> retrieving revision 1.593
> diff -u -p -r1.593 NEWS
> --- NEWS 16 Apr 2013 14:36:53 -0000 1.593
> +++ NEWS 6 May 2013 09:30:13 -0000
> @@ -3,6 +3,9 @@
>
> *** Changes since GDB 7.6
>
> +* The command 'history save' is now default enabled.
How about "is now enabled by default."

> +Disabled 'history save' on testsuiltes.
Maintainers can tell for sure but I think this does not need to be
added in NEWS.

> +
> * New commands:
> catch rethrow
> Like "catch throw", but catches a re-thrown exception.
>
>
> Thanks,
> -Bilal