From: Pedro Alves <palves@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
"Dr. David Alan Gilbert" <dave@treblig.org>
Subject: Re: [PATCH] Fix for PR 15413 (segfault when completing "condition" for pending bp)
Date: Mon, 06 May 2013 21:08:00 -0000 [thread overview]
Message-ID: <51881BCD.7070009@redhat.com> (raw)
In-Reply-To: <m3li7rsu6m.fsf@redhat.com>
On 05/06/2013 09:57 PM, Sergio Durigan Junior wrote:
> So, if I understood your brain dump correctly, you're suggesting that
> the "condition" command shouldn't complete multiple locations at all,
> since the condition is inherent to the breakpoint, not to the
> location(s). Is that right? I will submit a patch soon.
Yes. The patch to do that should be quite trivial,
mostly just removing/simplifying code, and it should fix the
segfault too as consequence, so I'd prefer focusing on a patch
that did that first (over trying to fix the existing bogus
multi-location code),
> [OTOH, I guess it would make more sense if the condition were a location
> property.]
and leave this for a separate discussion. The patch should then
be quite safe for 7.6 backporting too.
--
Pedro Alves
next prev parent reply other threads:[~2013-05-06 21:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 2:59 Sergio Durigan Junior
2013-05-06 17:49 ` Pedro Alves
2013-05-06 20:57 ` Sergio Durigan Junior
2013-05-06 21:08 ` Pedro Alves [this message]
2013-05-07 3:39 ` Sergio Durigan Junior
2013-05-07 16:16 ` Pedro Alves
2013-05-07 17:06 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51881BCD.7070009@redhat.com \
--to=palves@redhat.com \
--cc=dave@treblig.org \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox