From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30513 invoked by alias); 6 May 2013 09:40:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30500 invoked by uid 89); 6 May 2013 09:40:48 -0000 X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00,FROM_12LTRDOM,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 06 May 2013 09:40:47 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UZHuY-00001s-AW from Muhammad_Bilal@mentor.com ; Mon, 06 May 2013 02:40:46 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 6 May 2013 02:40:45 -0700 Received: from [137.202.157.37] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server (TLS) id 14.2.247.3; Mon, 6 May 2013 10:40:43 +0100 Message-ID: <51877A99.4060503@codesourcery.com> Date: Mon, 06 May 2013 09:40:00 -0000 From: mbilal User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: , , Subject: [PATCH 1/7] PR gdb/15224 should "set history save on" by default References: <51877A32.1030503@codesourcery.com> In-Reply-To: <51877A32.1030503@codesourcery.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00098.txt.bz2 On Wednesday, April 03, 2013 7:30 PM Jan Kratochvil wrote: > (1) Fix relative "set history filename" to by immediately converted to absolute form Here is a proposed patch with testcase. Index: cli/cli-setshow.c =================================================================== RCS file: /cvs/src/src/gdb/cli/cli-setshow.c,v retrieving revision 1.61 diff -u -p -r1.61 cli-setshow.c --- cli/cli-setshow.c 10 Apr 2013 15:11:12 -0000 1.61 +++ cli/cli-setshow.c 6 May 2013 05:23:46 -0000 @@ -22,6 +22,7 @@ #include "gdb_string.h" #include "arch-utils.h" #include "observer.h" +#include "filenames.h" #include "ui-out.h" @@ -247,6 +248,13 @@ do_set_command (char *arg, int from_tty, if (*(char **) c->var == NULL || strcmp (*(char **) c->var, val) != 0) { + if (strcmp (c->name, "filename") == 0) + { + if (!IS_ABSOLUTE_PATH (val)) + val = concat (current_directory, "/", val, + (char *)NULL); + } + xfree (*(char **) c->var); *(char **) c->var = val; Index: gdb.base/setshow.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/setshow.exp,v retrieving revision 1.30 diff -u -p -r1.30 setshow.exp --- gdb.base/setshow.exp 24 Apr 2013 14:29:17 -0000 1.30 +++ gdb.base/setshow.exp 6 May 2013 06:01:05 -0000 @@ -173,7 +173,8 @@ gdb_test "show history expansion on" "Hi gdb_test_no_output "set history filename foobar.baz" \ "set history filename foobar.baz" #test show history filename foobar.baz -gdb_test "show history filename" "The filename in which to record the command history is \"foobar.baz\"..*" "show history filename (foobar.baz)" +gdb_test "show history filename" "The filename in which to record the command history is \"[file join [pwd] foobar.baz]\"..*" \ + "show history filename \"[file join [pwd] foobar.baz]\"." #test set history save on gdb_test_no_output "set history save on" "set history save on" #test show history save on thanks, -Bilal