From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20373 invoked by alias); 3 May 2013 18:09:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20361 invoked by uid 89); 3 May 2013 18:09:27 -0000 X-Spam-SWARE-Status: No, score=-9.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS,TW_EG autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 03 May 2013 18:09:27 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r43I9Mnv023465 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 3 May 2013 14:09:22 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r43I9Kpj012626; Fri, 3 May 2013 14:09:21 -0400 Message-ID: <5183FD50.5080502@redhat.com> Date: Fri, 03 May 2013 18:09:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Sandra Loosemore CC: gdb-patches@sourceware.org, Joel Brobecker Subject: Re: [patch 3/4] Nios II gdbserver support, version 2 References: <5174820E.6090500@codesourcery.com> <20130426064547.GQ3525@adacore.com> <518332D1.9020709@codesourcery.com> In-Reply-To: <518332D1.9020709@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00061.txt.bz2 On 05/03/2013 04:45 AM, Sandra Loosemore wrote: > Here is a revised version of the gdbserver parts of the Nios II port. I've tweaked the copyright dates, comments, and formatting similarly to what I did to the GDB-side patches. I also made a few cleanups to the register-handling code to be consistent with the technical changes I made on the GDB side. > > OK to commit? Okay with nits below addressed. > +static CORE_ADDR > +nios2_get_pc (struct regcache *regcache) > +{ > + union nios2_register pc; Could you add an empty line after declarations (throughout), please? > +ps_err_e > +ps_get_thread_area (const struct ps_prochandle *ph, > + lwpid_t lwpid, int idx, void **base) > +{ > + if (ptrace (PTRACE_GET_THREAD_AREA, lwpid, NULL, base) != 0) > + return PS_ERR; > + > + /* IDX is the bias from the thread pointer to the beginning of the > + thread descriptor. It has to be subtracted due to implementation > + quirks in libthread_db. */ > + *base = (void *) ((char *)*base - idx); Missing space: '(char *) *base' > +struct regset_info target_regsets[] = { Put { on next line. > +struct linux_target_ops the_low_target = { Ditto. Thanks, -- Pedro Alves