From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1233 invoked by alias); 3 May 2013 15:26:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1223 invoked by uid 89); 3 May 2013 15:26:52 -0000 X-Spam-SWARE-Status: No, score=-9.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 03 May 2013 15:26:51 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r43FQWTf028715 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 3 May 2013 11:26:32 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r43FQUWg013224; Fri, 3 May 2013 11:26:30 -0400 Message-ID: <5183D725.4030107@redhat.com> Date: Fri, 03 May 2013 15:26:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: "Abid, Hafiz" CC: Yao Qi , gdb-patches@sourceware.org, stan@codesourcery.com, eliz@gnu.org Subject: Re: [patch] Change trace buffer size(v5) References: <1367593723.5163.2@abidh-ubunto1104> In-Reply-To: <1367593723.5163.2@abidh-ubunto1104> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00056.txt.bz2 On 05/03/2013 04:08 PM, Abid, Hafiz wrote: > I have attached a patch. It calls 'stop_tracing' from the QTinit handler. I was wondering that setting 'tracing' to 0 may be enough. But stop_tracing seems to do a lot of other things which may be required. So I thought it is better to go with it. Right. > Another possibility is to let QTBuffer:size handler return ok if the new size is equal to current size irrespective of the value of 'tracing'. I'd rather not add special cases. > As I mentioned earlier, a testcase was already present for this scenario but > it was missing the error message that came after we press 'y'. I have handled > it but would like to know if there is a better way to do it. Looks like a good solution. > proc test_tstart_tstart { } { > with_test_prefix "tstart_tstart" { > + global gdb_prompt > global executable > global hex This looks unnecessary. Otherwise OK for mainline and 7.6. Thanks! -- Pedro Alves