From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24788 invoked by alias); 2 May 2013 17:23:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24773 invoked by uid 89); 2 May 2013 17:23:36 -0000 X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 02 May 2013 17:23:35 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r42HNWRf022487 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 2 May 2013 13:23:32 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r42HNUe2015034; Thu, 2 May 2013 13:23:31 -0400 Message-ID: <5182A112.3050303@redhat.com> Date: Thu, 02 May 2013 17:23:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: David Taylor CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix for QTro remote packet References: <10772.1367429886@usendtaylorx2l> In-Reply-To: <10772.1367429886@usendtaylorx2l> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-05/txt/msg00038.txt.bz2 On 05/01/2013 06:38 PM, David Taylor wrote: > In function remote_trace_set_readonly_regions in gdb/remote.c, the local > variable 'offset' does not account for "QTro" at the start of the packet > with the result that if there are any read-only regions, the packet is > sent -- but without the "QTro" -- causing the remote stub to report that > the packet is unsupported. Sigh. Clearly the Jun 2011 change to this function wasn't properly tested. :-/ > 2013-05-01 David Taylor > > * remote.c (remote_trace_set_readonly_regions): Do not overwrite > "QTro" at start of packet. OK, thanks. -- Pedro Alves