Re: [patch 2/2] Assert leftover cleanups in TRY_CATCH

Tom Tromey
2013-05-07T15:26:34Z

Tom> Alternatively I think we could probably change all the code to be
Tom> cleanup-checker-clean. I'll try to prep that series soon to see what
Tom> people think. I think it actually less work.

Actually, I forgot how hard this is.

There are some tricky cases -- e.g., try to remove the dangling cleanup
from c-exp.y:operator_stoken, or from
ada-lang.c:old_renaming_is_invisible.

Or, there is some spaghetti code, like
disasm.c:do_mixed_source_and_assembly.

And, there is some code where I don't know what is intended, like
record-full.c:record_full_wait_1 (multiple returns without cleaning up),
or record-btrace.c:record_btrace_insn_history.

So, getting to zero complaints from the checker is not easy.
Maybe I will hack the checker to ignore some issues.

Tom