From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11785 invoked by alias); 26 Apr 2013 17:33:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11773 invoked by uid 89); 26 Apr 2013 17:33:23 -0000 X-Spam-SWARE-Status: No, score=-7.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 26 Apr 2013 17:33:23 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3QHX8qm006137 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 26 Apr 2013 13:33:08 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r3QHX6EI011175; Fri, 26 Apr 2013 13:33:07 -0400 Message-ID: <517ABA52.6000603@redhat.com> Date: Fri, 26 Apr 2013 19:13:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: "Blanc, Nicolas" CC: Tom Tromey , "gdb-patches@sourceware.org" Subject: Re: [PATCH 0/3] remove-symbol-file References: <1366098721-18302-1-git-send-email-nicolas.blanc@intel.com> <8761zdow5j.fsf@fleche.redhat.com> <388084C8C1E6A64FA36AD1D656E4856619DEEE98@IRSMSX102.ger.corp.intel.com> <51781A68.4010004@redhat.com> <388084C8C1E6A64FA36AD1D656E4856619DEF279@IRSMSX102.ger.corp.intel.com> In-Reply-To: <388084C8C1E6A64FA36AD1D656E4856619DEF279@IRSMSX102.ger.corp.intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-04/txt/msg00817.txt.bz2 On 04/25/2013 09:38 AM, Blanc, Nicolas wrote: > > >>> session. In this context I think the text address is the most appropriate way to remove a file because: >>> 1) the user knows exactly where the .text section was loaded, >> >> So how do you handle the case of there being no .text section at all? > > It's a requirement of the add-symbol-file command [1]. The existing implementation of add-symbol-file assumes > that the *mandatory* load-address argument (terminology from GDB's manual) is the address of the text section. > See the implementation of add-symbol-file: > > if (argcnt == 1) > { > /* The second argument is always the text address at which > to load the program. */ > sect_opts[section_index].name = ".text"; > > The second argument is not optional. The add-symbol-file command returns an error if no address is specified. As I mentioned before, in the add case, you can just pass in a random ADDR, I think gdb copes: (gdb) add-symbol-file ~/data.o 0x111 -s .data 0x2000 add symbol table from file "/home/pedro/data.o" at .text_addr = 0x111 .data_addr = 0x2000 (y or n) y Reading symbols from /home/pedro/data.o...warning: section .text not found in /home/pedro/data.o >>> Note that currently in Option 4 below ADDR is in fact >>> "objf->addr_low", but the command could be more generous by searching >>> first which file corresponds to ADDR and then removing it. This would be more flexible and an alternative to Option 3, for instance. >> You lost me here. > > It's an idea that you and Tom gave me. Given an arbitrary address, remove-symbol-file could figure out the file that > corresponds to this address and remove it. This could make the command more flexible. Hmm, how is that different from what the command is currently doing? /me looks > But thinking twice I think that the current > implementation of remove-symbol-file does the right thing by identifying the file to remove using the address from the > add-symbol-file command. The user knows what address he passed to add-symbol-file. Ah, so the current implementation stores the ADDR the user specified with add-symbol-file. Why didn't you say so? ;-) Okay, I guess that's good enough. We can add support for "-s" too to remove- if ever necessary. >>> 1) remove-symbol-file FILE >>> 2) remove-symbol-file FILE ADDR >>> 3) remove-symbol-file -s .data DATA_ADDR >>> 4) remove-symbol-file ADDR -- Pedro Alves