From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5899 invoked by alias); 26 Apr 2013 06:10:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5887 invoked by uid 89); 26 Apr 2013 06:10:28 -0000 X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 26 Apr 2013 06:10:27 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UVbrU-0003PO-QW from Yao_Qi@mentor.com ; Thu, 25 Apr 2013 23:10:24 -0700 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 25 Apr 2013 23:10:24 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.2.247.3; Thu, 25 Apr 2013 23:10:23 -0700 Message-ID: <517A1A4C.6020207@codesourcery.com> Date: Fri, 26 Apr 2013 14:13:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: "Blanc, Nicolas" CC: "gdb-patches@sourceware.org" , Tom Tromey , Pedro Alves Subject: Re: [PATCH 1/3] Added command remove-symbol-file. References: <1366098721-18302-1-git-send-email-nicolas.blanc@intel.com> <1366098721-18302-2-git-send-email-nicolas.blanc@intel.com> <87fvygnfl0.fsf@fleche.redhat.com> <388084C8C1E6A64FA36AD1D656E4856619DEF314@IRSMSX102.ger.corp.intel.com> In-Reply-To: <388084C8C1E6A64FA36AD1D656E4856619DEF314@IRSMSX102.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-04/txt/msg00802.txt.bz2 On 04/25/2013 08:48 PM, Blanc, Nicolas wrote: > Tom> I liked Yao's comment about notifying just once per breakpoint. It doesn't seem difficult to do that. > Nicolas> Ok I'll use a list of breakpoints to collect first the breakpoints to notify. You may have a look at tracepoint.c:merge_uploaded_tracepoints, and see how to notify once for one breakpoint. We use a vector 'modified_tp' there to save the modified breakpoint uniquely, iterate over it, and call observer_notify_breakpoint_modified. Hope it helps. -- Yao (齐尧)