From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6807 invoked by alias); 24 Apr 2013 17:46:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6797 invoked by uid 89); 24 Apr 2013 17:46:25 -0000 X-Spam-SWARE-Status: No, score=-8.4 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 24 Apr 2013 17:46:24 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3OHkJGW017280 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 24 Apr 2013 13:46:19 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r3OHkHNr022925; Wed, 24 Apr 2013 13:46:18 -0400 Message-ID: <51781A68.4010004@redhat.com> Date: Wed, 24 Apr 2013 20:49:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: "Blanc, Nicolas" CC: Tom Tromey , "gdb-patches@sourceware.org" Subject: Re: [PATCH 0/3] remove-symbol-file References: <1366098721-18302-1-git-send-email-nicolas.blanc@intel.com> <8761zdow5j.fsf@fleche.redhat.com> <388084C8C1E6A64FA36AD1D656E4856619DEEE98@IRSMSX102.ger.corp.intel.com> In-Reply-To: <388084C8C1E6A64FA36AD1D656E4856619DEEE98@IRSMSX102.ger.corp.intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-04/txt/msg00750.txt.bz2 On 04/24/2013 06:30 PM, Blanc, Nicolas wrote: > Thanks Tom, Pedro for your feedback. > > I'll try to respond to both of you in this email. > > This implementation only removes files that were added via the add-symbol-file command. > The add-symbol-file command takes as parameter the address of the text session. In this > context I think the text address is the most appropriate way to remove a file because: > 1) the user knows exactly where the .text section was loaded, So how do you handle the case of there being no .text section at all? > 2) an application can load shared libraries several times at different addresses (it's a requirement for me), and > 3) I can't think of a good reason why someone would add a second symbol file at the same address. > Most likely this is a user error that should have been reported by add-symbol-file. > > Note that currently in Option 4 below ADDR is in fact "objf->addr_low", but the command could be more generous > by searching first which file corresponds to ADDR and then removing it. This would be more flexible and an > alternative to Option 3, for instance. You lost me here. > > 1) remove-symbol-file FILE > 2) remove-symbol-file FILE ADDR > 3) remove-symbol-file -s .data DATA_ADDR > 4) remove-symbol-file ADDR -- Pedro Alves