From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19774 invoked by alias); 24 Apr 2013 15:04:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19763 invoked by uid 89); 24 Apr 2013 15:04:02 -0000 X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 24 Apr 2013 15:04:01 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UV1El-0006HT-7j from Yao_Qi@mentor.com ; Wed, 24 Apr 2013 08:03:59 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 24 Apr 2013 08:03:59 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Wed, 24 Apr 2013 08:03:58 -0700 Message-ID: <5177F457.1000209@codesourcery.com> Date: Wed, 24 Apr 2013 18:58:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Hui Zhu CC: gdb-patches ml , Joel Brobecker Subject: Re: [PATCH/7.6] Fix wrong release (maybe crash GDB) in build_target_command_list References: In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-04/txt/msg00742.txt.bz2 On 04/24/2013 09:29 PM, Hui Zhu wrote: > - if (!loc->cond_bytecode) > + if (!loc->cmd_bytecode) Nit: "if (loc->cmd_bytecode == NULL)" is better. -- Yao (齐尧)