From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-100787-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 23181 invoked by alias); 23 Apr 2013 17:13:51 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 23171 invoked by uid 89); 23 Apr 2013 17:13:51 -0000
X-Spam-SWARE-Status: No, score=-8.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 23 Apr 2013 17:13:50 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3NHDnjW017857	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Tue, 23 Apr 2013 13:13:49 -0400
Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3NHDlks012145	(version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);	Tue, 23 Apr 2013 13:13:48 -0400
Message-ID: <5176C14B.6010603@redhat.com>
Date: Wed, 24 Apr 2013 06:06:00 -0000
From: Keith Seitz <keiths@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5
MIME-Version: 1.0
To: Hui Zhu <teawater@gmail.com>
CC: gdb-patches@sourceware.org
Subject: Re: [RFC] PR 15075 dprintf interferes with "next"
References: <1361192891-29341-1-git-send-email-yao@codesourcery.com> <8738wpd3qe.fsf@fleche.redhat.com> <CANFwon3DymreN3ost7ZSrd0deb_sBC6YTzk1fpv8k+7d0ADnLg@mail.gmail.com>
In-Reply-To: <CANFwon3DymreN3ost7ZSrd0deb_sBC6YTzk1fpv8k+7d0ADnLg@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2013-04/txt/msg00713.txt.bz2

On 04/23/2013 08:44 AM, Hui Zhu wrote:
> --- a/gdb/breakpoint.c
> +++ b/gdb/breakpoint.c
> +/* Implement the "after_cond"  breakpoint_ops method for dprintf.  */
> +
> +static void
> +dprintf_after_cond (struct bpstats *bs)
> +{
> +  bpstat tmp;
> +
> +  bs->stop = 0;
> +  bs->print = 0;
> +  bs->commands = b->commands;
> +  tmp = bs->next;
> +  bs->next = tmp;
> +  incref_counted_command_line (bs->commands);
> +  bpstat_do_actions_1 (&bs);
> +  bs->next = tmp;
> +}

This function must be incomplete. What is 'tmp' for? It is superfluous 
as written. 'b' is undefined, too.

Keith