From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23603 invoked by alias); 22 Apr 2013 23:47:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23592 invoked by uid 89); 22 Apr 2013 23:47:58 -0000 X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 22 Apr 2013 23:47:57 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UUQSi-0002gJ-23 from Sandra_Loosemore@mentor.com for gdb-patches@sourceware.org; Mon, 22 Apr 2013 16:47:56 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 22 Apr 2013 16:47:55 -0700 Received: from [IPv6:::1] (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.2.247.3; Mon, 22 Apr 2013 16:47:37 -0700 Message-ID: <5175CC11.7060905@codesourcery.com> Date: Tue, 23 Apr 2013 09:33:00 -0000 From: Sandra Loosemore User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: "Joseph S. Myers" CC: Subject: Re: [patch 3/4] Nios II gdbserver support References: <5174820E.6090500@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-04/txt/msg00691.txt.bz2 On 04/22/2013 03:05 PM, Joseph S. Myers wrote: > On Sun, 21 Apr 2013, Sandra Loosemore wrote: > >> + Copyright (C) 2008, 2012, 2013 >> + Free Software Foundation, Inc. > > GDB now uses copyright year ranges, so > > Copyright (C) 2008-2013 Free Software Foundation, Inc. > > (all on one line) and likewise for any other new files in this patch > series. Hmmm, I thought the year range was only acceptable when there were actually modifications to the file in all of those years? >> +#ifndef PTRACE_GET_THREAD_AREA >> +#define PTRACE_GET_THREAD_AREA 25 >> +#endif > > The same comment I made on the AArch64 port applies here: for native code > in new ports, as opposed to use of new definitions in existing ports, you > should just be able to assume recent-enough headers (at least until the > Linux kernel port goes upstream, at which point the first upstream release > with the code can be the minimum version of kernel headers supported) > rather than having such #if conditionals. I'm not sure what change you want here. If I remove that block of code, the file fails to compile with the kernel headers currently being provided by Altera, which do not define PTRACE_GET_THREAD_AREA. -Sandra