From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24505 invoked by alias); 22 Apr 2013 14:54:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24495 invoked by uid 89); 22 Apr 2013 14:54:26 -0000 X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 22 Apr 2013 14:54:26 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3MEsNbu005773 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 22 Apr 2013 10:54:23 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3MEsMlf018802; Mon, 22 Apr 2013 10:54:22 -0400 Message-ID: <51754F1D.9000300@redhat.com> Date: Mon, 22 Apr 2013 21:06:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: lgustavo@codesourcery.com CC: "'gdb-patches@sourceware.org'" Subject: Re: [PATCH, remote] Handle 'k' packet errors gracefully References: <517549FC.5070606@codesourcery.com> In-Reply-To: <517549FC.5070606@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-04/txt/msg00673.txt.bz2 Hi Luis, On 04/22/2013 03:32 PM, Luis Machado wrote: > This is not a real problem with gdbserver, but other types of remote targets (other stubs, QEMU etc) may cut the connection abruptly since they are not required to reply to a 'k' (Kill) packet sent from GDB. > > The following patch addresses any issues arising from such scenario, which leads to a GDB internal error due to an attempt to pop the target more than once. With the patch, this failure is handled gracefully. Hard to say without at least seeing the backtrace, but this may no longer be applicable due to changes in this area since (some quite recent). > As the ChangeLog suggests, i'm sending this on behalf of its original authors. This needs to be updated to take the new TARGET_CLOSE_ERROR exception into account. Thanks, -- Pedro Alves