From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-100715-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29882 invoked by alias); 20 Apr 2013 08:20:19 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 29872 invoked by uid 89); 20 Apr 2013 08:20:19 -0000
X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sat, 20 Apr 2013 08:20:18 +0000
Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58])	by relay1.mentorg.com with esmtp 	id 1UTT1r-00066v-75 from Yao_Qi@mentor.com ; Sat, 20 Apr 2013 01:20:15 -0700
Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675);	 Sat, 20 Apr 2013 01:20:15 -0700
Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.2.247.3; Sat, 20 Apr 2013 01:20:13 -0700
Message-ID: <51724F9A.4070204@codesourcery.com>
Date: Mon, 22 Apr 2013 01:25:00 -0000
From: Yao Qi <yao@codesourcery.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2
MIME-Version: 1.0
To: Hui Zhu <teawater@gmail.com>
CC: Pedro Alves <palves@redhat.com>, Eli Zaretskii <eliz@gnu.org>, Hui Zhu	<hui_zhu@mentor.com>, gdb-patches ml <gdb-patches@sourceware.org>, Marc Khouzam <marc.khouzam@ericsson.com>
Subject: Re: [PATCH] add -s option to make -break-insert support dprintf
References: <515451EA.1000200@mentor.com> <83y5d7wpvq.fsf@gnu.org> <CANFwon23qn_SVjcUWUZ2Z2Y5Euqg8efiwMvXkxTRtA9-2Ttk3Q@mail.gmail.com> <516454DA.9040109@redhat.com> <CANFwon1aDoyCYrsNeUpkmh6ARFJmT8B4JdFqYcc6GLdo=cgqig@mail.gmail.com> <51667EDC.9070207@redhat.com> <CANFwon1_xBW8kcLw__tJV_Lnv5uhVSTycR-4651pYydvaa8rZw@mail.gmail.com> <5167F13F.6090007@redhat.com> <CANFwon0MPymGC12ZUYYy_C+yNCBSOMFK4uK9DdivCAjdcu5N9w@mail.gmail.com>
In-Reply-To: <CANFwon0MPymGC12ZUYYy_C+yNCBSOMFK4uK9DdivCAjdcu5N9w@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-SW-Source: 2013-04/txt/msg00641.txt.bz2

On 04/15/2013 10:57 PM, Hui Zhu wrote:
> +	mi_run_cmd
> +	set msg "mi 1st dprintf"
> +	gdb_expect {
> +            -re ".*At foo entry.*arg=1234, g=1234.*" {

Hui,
Probably we need to remove the trailing ".*" above.  Then, the rest of 
the output will be matched ...


> +		pass $msg
> +	    }
> +	    -re ".*$mi_gdb_prompt$" {
> +		fail $msg
> +	    }
> +            timeout {
> +		fail $msg
> +            }
> +	}
> +	mi_expect_stop ".*" ".*" ".*" ".*" ".*" "" "$msg stop"

... here.

> +
> +	set msg "mi 2nd dprintf"
> +	mi_send_resuming_command "exec-continue" "$msg continue"
> +	gdb_expect {
> +            -re ".*At foo entry.*arg=1235, g=2222.*" {

We need append "$mi_gdb_prompt$" to the end of the pattern above to eat 
all the output, otherwise, these output will make troubles to the rest 
of the tests.

> +		pass $msg
> +	    }
> +	    -re ".*$mi_gdb_prompt$" {
> +		fail $msg
> +	    }
> +            timeout {
> +		fail $msg
> +            }
> +	}

I can get some fails on my machine, similar to fails that Pedro pointed 
out.  With these change above, I don't see fails any more.

b.t.w,

+# To make sure set dprintf-style agent get right output.
+mi_gdb_test "pwd" ".*"

This line is odd to me, and looks it only papers over the problem 
somewhere else.

-- 
Yao (齐尧)