From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-100691-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27592 invoked by alias); 19 Apr 2013 16:44:36 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 27581 invoked by uid 89); 19 Apr 2013 16:44:36 -0000
X-Spam-SWARE-Status: No, score=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 19 Apr 2013 16:44:35 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3JGiXch005473	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Fri, 19 Apr 2013 12:44:33 -0400
Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3JGiWeE010692	(version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);	Fri, 19 Apr 2013 12:44:33 -0400
Message-ID: <51717470.4010801@redhat.com>
Date: Fri, 19 Apr 2013 18:36:00 -0000
From: Keith Seitz <keiths@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130402 Thunderbird/17.0.5
MIME-Version: 1.0
To: Hui Zhu <teawater@gmail.com>
CC: Tom Tromey <tromey@redhat.com>,        gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Let dprintf can be saved
References: <CANFwon0p7x4X1qx=kqu-XRJ0XYfv8NDW4WxqST=w16VDUZTSzw@mail.gmail.com> <87fvymwkbi.fsf@fleche.redhat.com>
In-Reply-To: <87fvymwkbi.fsf@fleche.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2013-04/txt/msg00617.txt.bz2

On 04/19/2013 09:34 AM, Tom Tromey wrote:
> I think this patch could use a test case.
> It could be added wherever the existing "save" tests live.

Those are in save-bp.exp.

If I may be so bold, I would like to request that tests are added for 
saving pending dprintfs, too, both before and after resolution.

I noticed a multitude of save breakpoint problems w.r.t. pending 
breakpoints (a number of which my explicit location patch fixes).

Keith