From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97651 invoked by alias); 12 Nov 2018 16:17:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97632 invoked by uid 89); 12 Nov 2018 16:17:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,MIME_BASE64_BLANKS,SPF_PASS autolearn=ham version=3.3.2 spammy=am, UD:m X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Nov 2018 16:17:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1542039444; x=1544631444; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=598sfj8U0oje+8P5P6f9FAAteEO4eiGYh4Xy3/DIm+A=; b=EMnFBQjrwtRuoFiafhbtb5IHPsWy6DB5TLd6eecdQKqJ7RbUo7li77ljAFDNhNqx s8CthvpxovHQC2lWG8fNL3N4bIvpFMGyIg6z38isgE9ESt/76WYGKFuunh0ROWzH ILpccWujpUp8uHW967XA+GSkWkQO1/Uyex58MgqJtBE=; Received: from ESESBMB505.ericsson.se (Unknown_Domain [153.88.183.118]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 76.9F.06431.497A9EB5; Mon, 12 Nov 2018 17:17:24 +0100 (CET) Received: from ESESBMR501.ericsson.se (153.88.183.129) by ESESBMB505.ericsson.se (153.88.183.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Mon, 12 Nov 2018 17:17:21 +0100 Received: from ESESSMB503.ericsson.se (153.88.183.164) by ESESBMR501.ericsson.se (153.88.183.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Mon, 12 Nov 2018 17:17:21 +0100 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB503.ericsson.se (153.88.183.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Mon, 12 Nov 2018 17:17:21 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=598sfj8U0oje+8P5P6f9FAAteEO4eiGYh4Xy3/DIm+A=; b=Eed4Aq0xy98xbyvSPpBrZP1bsh0te+uuZa55r0+P0pvfTaWGDRi1UgA8RTuhr3JAvbW6dfHmMsl4yxOKsnmoaCFpN6qmFWCgowzp5aCmxJMwxlH1XvwYpvRnvu1r0vzXS2DCDlhBt9QvTUobhCt5kWkeyN9tELwjvUOFz1O/RMM= Received: from BYAPR15MB2390.namprd15.prod.outlook.com (52.135.198.30) by BYAPR15MB2488.namprd15.prod.outlook.com (52.135.200.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.28; Mon, 12 Nov 2018 16:17:18 +0000 Received: from BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::649a:ddbf:ecc5:1f0a]) by BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::649a:ddbf:ecc5:1f0a%3]) with mapi id 15.20.1294.044; Mon, 12 Nov 2018 16:17:18 +0000 From: Simon Marchi To: Philippe Waroquiers , "gdb-patches@sourceware.org" Subject: Re: [RFAv2] Fix leak in displaced step. Date: Mon, 12 Nov 2018 16:17:00 -0000 Message-ID: <516d7e99-79da-9939-7ff0-ca79942985c8@ericsson.com> References: <20181111121137.6832-1-philippe.waroquiers@skynet.be> In-Reply-To: <20181111121137.6832-1-philippe.waroquiers@skynet.be> authentication-results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Content-Type: text/plain; charset="utf-8" Content-ID: <92438F700243084281D7692D9568DFC6@namprd15.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Return-Path: simon.marchi@ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00211.txt.bz2 T24gMjAxOC0xMS0xMSA3OjExIGEubS4sIFBoaWxpcHBlIFdhcm9xdWllcnMg d3JvdGU6DQo+IFZhbGdyaW5kIHJlcG9ydHMgYSBkZWZpbml0ZSBsZWFrIG9m IGRpc3BsYWNlZC0+c3RlcF9zYXZlZF9jb3B5DQo+IChmdWxsIGxlYWsgc3Rh Y2sgdHJhY2UgYmVsb3cpLg0KPiANCj4gVGhpcyBwYXRjaCBmaXhlcyB0aGUg bGVhayBieSBvbmx5IGFsbG9jYXRpbmcgYSBuZXcgc3RlcF9zYXZlZF9jb3B5 DQo+IGlmIHRoZSBwcm9jZXNzIGRpc3BsYWNlZF9zdGVwX2luZmVyaW9yX3N0 YXRlIGRvZXMgbm90IHlldCBoYXZlIG9uZSwNCj4gYW5kIGJ5IGZyZWVpbmcg aXQgd2hlbiB0aGUgZGlzcGxhY2VkX3N0ZXBfaW5mZXJpb3Jfc3RhdGUgb2Yg YSBwcm9jZXNzDQo+IGlzIHJlbW92ZWQsIHdoZW4gdGhlIGluZmVyaW9yIGV4 aXRzLg0KPiANCj4gUmVndGVzdGVkIG9uIGRlYmlhbi9hbWQ2NCArIHN0ZXAt b3Zlci1zeXNjYWxsLmV4cCByZXJ1biB1bmRlciB2YWxncmluZC4NCj4gDQo+ ID09NDczNj09IFZBTEdSSU5EX0dEQl9FUlJPUl9CRUdJTg0KPiA9PTQ3MzY9 PSAxMjggYnl0ZXMgaW4gOCBibG9ja3MgYXJlIGRlZmluaXRlbHkgbG9zdCBp biBsb3NzIHJlY29yZCA5ODAgb2YgMywxMDgNCj4gPT00NzM2PT0gICAgYXQg MHg0QzJCRTJEOiBtYWxsb2MgKHZnX3JlcGxhY2VfbWFsbG9jLmM6Mjk5KQ0K PiA9PTQ3MzY9PSAgICBieSAweDQxQjYyNzogeG1hbGxvYyAoY29tbW9uLXV0 aWxzLmM6NDQpDQo+ID09NDczNj09ICAgIGJ5IDB4NTBENEUzOiBkaXNwbGFj ZWRfc3RlcF9wcmVwYXJlX3Rocm93IChpbmZydW4uYzoxODM3KQ0KPiA9PTQ3 MzY9PSAgICBieSAweDUwRDRFMzogZGlzcGxhY2VkX3N0ZXBfcHJlcGFyZSAo aW5mcnVuLmM6MTg5OCkNCj4gPT00NzM2PT0gICAgYnkgMHg1MEQ0RTM6IHJl c3VtZV8xIChpbmZydW4uYzoyNTQ1KQ0KPiA9PTQ3MzY9PSAgICBieSAweDUw RDRFMzogcmVzdW1lKGdkYl9zaWduYWwpIChpbmZydW4uYzoyNzQxKQ0KPiA9 PTQ3MzY9PSAgICBieSAweDUwRENENToga2VlcF9nb2luZ19wYXNzX3NpZ25h bChleGVjdXRpb25fY29udHJvbF9zdGF0ZSopIChpbmZydW4uYzo3NzkzKQ0K PiA9PTQ3MzY9PSAgICBieSAweDUwRTkwMzogcHJvY2Vzc19ldmVudF9zdG9w X3Rlc3QoZXhlY3V0aW9uX2NvbnRyb2xfc3RhdGUqKSAoaW5mcnVuLmM6Njg0 MykNCj4gPT00NzM2PT0gICAgYnkgMHg1MTA5MjU6IGhhbmRsZV9zaWduYWxf c3RvcChleGVjdXRpb25fY29udHJvbF9zdGF0ZSopIChpbmZydW4uYzo2MTc2 KQ0KPiA9PTQ3MzY9PSAgICBieSAweDUxM0Y3OTogaGFuZGxlX2luZmVyaW9y X2V2ZW50XzEgKGluZnJ1bi5jOjUzNTQpDQo+ID09NDczNj09ICAgIGJ5IDB4 NTEzRjc5OiBoYW5kbGVfaW5mZXJpb3JfZXZlbnQoZXhlY3V0aW9uX2NvbnRy b2xfc3RhdGUqKSAoaW5mcnVuLmM6NTM4OSkNCj4gPT00NzM2PT0gICAgYnkg MHg1MTU0MUI6IGZldGNoX2luZmVyaW9yX2V2ZW50KHZvaWQqKSAoaW5mcnVu LmM6MzkxNikNCj4gPT00NzM2PT0gICAgYnkgMHg0QjNFRUM6IGdkYl93YWl0 X2Zvcl9ldmVudChpbnQpIChldmVudC1sb29wLmM6ODU5KQ0KPiA9PTQ3MzY9 PSAgICBieSAweDRCM0ZGNjogZ2RiX2RvX29uZV9ldmVudCgpIFtjbG9uZSAu cGFydC40XSAoZXZlbnQtbG9vcC5jOjMyMikNCj4gPT00NzM2PT0gICAgYnkg MHg0QjQxQjQ6IGdkYl9kb19vbmVfZXZlbnQgKGNvbW1vbi1leGNlcHRpb25z Lmg6MjE5KQ0KPiA9PTQ3MzY9PSAgICBieSAweDRCNDFCNDogc3RhcnRfZXZl bnRfbG9vcCgpIChldmVudC1sb29wLmM6MzcxKQ0KPiA9PTQ3MzY9PSAgICBi eSAweDU1MTIzNzogY2FwdHVyZWRfY29tbWFuZF9sb29wKCkgKG1haW4uYzoz MzApDQo+ID09NDczNj09ICAgIGJ5IDB4NTUyMjJDOiBjYXB0dXJlZF9tYWlu IChtYWluLmM6MTE3NykNCj4gPT00NzM2PT0gICAgYnkgMHg1NTIyMkM6IGdk Yl9tYWluKGNhcHR1cmVkX21haW5fYXJncyopIChtYWluLmM6MTE5MykNCj4g PT00NzM2PT0gICAgYnkgMHgyOUI0Rjc6IG1haW4gKGdkYi5jOjMyKQ0KPiA9 PTQ3MzY9PQ0KPiA9PTQ3MzY9PSBWQUxHUklORF9HREJfRVJST1JfRU5EDQo+ IA0KPiBnZGIvQ2hhbmdlTG9nDQo+IA0KPiAyMDE4LTExLTExICBQaGlsaXBw ZSBXYXJvcXVpZXJzICA8cGhpbGlwcGUud2Fyb3F1aWVyc0Bza3luZXQuYmU+ DQo+IA0KPiAJKiBpbmZydW4uYyAoZGlzcGxhY2VkX3N0ZXBfaW5mZXJpb3Jf c3RhdGUpOiBFeHBsYWluIHdoeSBzdGVwX3NhdmVkX2NvcHkNCj4gCWlzIHNv bWV0aW1lcyBuZWVkZWQgYWZ0ZXIgdGhlIHN0ZXAtb3ZlciBpcyBmaW5pc2hl ZC4NCj4gCShyZW1vdmVfZGlzcGxhY2VkX3N0ZXBwaW5nX3N0YXRlKTogeGZy ZWUgc3RlcF9zYXZlZF9jb3B5Lg0KPiAJKGRpc3BsYWNlZF9zdGVwX2NsZWFy KTogQWRkIG5vdGUgdGhhdCBleHBsYWlucyB3aHkgd2UgZG8gbm90IHhmcmVl DQo+IAlzdGVwX3NhdmVkX2NvcHkgaGVyZS4NCj4gLS0tDQo+ICBnZGIvaW5m cnVuLmMgfCAyMyArKysrKysrKysrKysrKysrKysrKystLQ0KPiAgMSBmaWxl IGNoYW5nZWQsIDIxIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pDQo+ IA0KPiBkaWZmIC0tZ2l0IGEvZ2RiL2luZnJ1bi5jIGIvZ2RiL2luZnJ1bi5j DQo+IGluZGV4IDk0NzNkMWYyMGYuLjFjNDBjYjJlMGYgMTAwNjQ0DQo+IC0t LSBhL2dkYi9pbmZydW4uYw0KPiArKysgYi9nZGIvaW5mcnVuLmMNCj4gQEAg LTE1MTAsNyArMTUxMCwxMyBAQCBzdHJ1Y3QgZGlzcGxhY2VkX3N0ZXBfaW5m ZXJpb3Jfc3RhdGUNCj4gICAgICAgbWFkZS4gICovDQo+ICAgIENPUkVfQURE UiBzdGVwX29yaWdpbmFsLCBzdGVwX2NvcHk7DQo+ICANCj4gLSAgLyogU2F2 ZWQgY29udGVudHMgb2YgY29weSBhcmVhLiAgKi8NCj4gKyAgLyogU2F2ZWQg Y29udGVudHMgb2YgY29weSBhcmVhLiAgSW4gbW9zdCBjYXNlcywgd2UgY291 bGQgZ2V0IHJpZA0KPiArICAgICBvZiB0aGlzIGNvcHkgd2hlbiB0aGUgZGlz cGxhY2VkIHNpbmdsZS1zdGVwIGlzIGZpbmlzaGVkLCBhZnRlcg0KPiArICAg ICBoYXZpbmcgcmVzdG9yZWQgdGhlIGNvbnRlbnQsIHdoZW4gc2V0dGluZyBz dGVwX3RocmVhZCB0byBudWxscHRyLg0KPiArICAgICBIb3dldmVyLCB3ZSBu ZWVkIHRvIGtlZXAgdGhpcyBjb250ZW50IGluIGNhc2UgdGhlIHN0ZXAtb3Zl ciBpcw0KPiArICAgICBvdmVyIGEgZm9yayBzeXNjYWxsOiBpbiBzdWNoIGEg Y2FzZSwgdGhlIHN0ZXAtb3ZlciB3YXMgZG9uZSBpbg0KPiArICAgICB0aGUg cGFyZW50LCBidXQgd2UgYWxzbyBoYXZlIHRvIHJlc3RvcmUgdGhlIGNvcHkg YXJlYSBjb250ZW50DQo+ICsgICAgIGluIHRoZSBjaGlsZCwgYWZ0ZXIgdGhl IHBhcmVudCBoYXMgZmluaXNoZWQgdGhlIHN0ZXAtb3Zlci4gICovDQo+ICAg IGdkYl9ieXRlICpzdGVwX3NhdmVkX2NvcHk7DQo+ICB9Ow0KPiAgDQo+IEBA IC0xNjM4LDYgKzE2NDQsMTEgQEAgcmVtb3ZlX2Rpc3BsYWNlZF9zdGVwcGlu Z19zdGF0ZSAoaW5mZXJpb3IgKmluZikNCj4gICAgICAgIGlmIChpdC0+aW5m ID09IGluZikNCj4gIAl7DQo+ICAJICAqcHJldl9uZXh0X3AgPSBpdC0+bmV4 dDsNCj4gKwkgIGlmIChpdC0+c3RlcF9zYXZlZF9jb3B5ICE9IE5VTEwpDQo+ ICsJICAgIHsNCj4gKwkgICAgICB4ZnJlZSAoaXQtPnN0ZXBfc2F2ZWRfY29w eSk7DQo+ICsJICAgICAgaXQtPnN0ZXBfc2F2ZWRfY29weSA9IE5VTEw7DQo+ ICsJICAgIH0NCj4gIAkgIHhmcmVlIChpdCk7DQo+ICAJICByZXR1cm47DQo+ ICAJfQ0KPiBAQCAtMTcwOSw2ICsxNzIwLDEwIEBAIGRpc3BsYWNlZF9zdGVw X2NsZWFyIChzdHJ1Y3QgZGlzcGxhY2VkX3N0ZXBfaW5mZXJpb3Jfc3RhdGUg KmRpc3BsYWNlZCkNCj4gIA0KPiAgICBkZWxldGUgZGlzcGxhY2VkLT5zdGVw X2Nsb3N1cmU7DQo+ICAgIGRpc3BsYWNlZC0+c3RlcF9jbG9zdXJlID0gTlVM TDsNCj4gKw0KPiArICAvKiBOb3RlOiB3ZSBjYW5ub3QgeGZyZWUgKGRpc3Bs YWNlZC0+c3RlcF9zYXZlZF9jb3B5KSwgYXMgdGhpcw0KPiArICAgICBpcyBu ZWVkZWQgdG8gcmVzdG9yZSB0aGUgY29udGVudCBpbiB0aGUgY2hpbGQsIGlm DQo+ICsgICAgIHRoZSBzdGVwLW92ZXIgd2FzIG92ZXIgYSBmb3JrIHN5c2Nh bGwuICAqLw0KPiAgfQ0KPiAgDQo+ICBzdGF0aWMgdm9pZA0KPiBAQCAtMTgz NCw3ICsxODQ5LDExIEBAIGRpc3BsYWNlZF9zdGVwX3ByZXBhcmVfdGhyb3cg KHRocmVhZF9pbmZvICp0cCkNCj4gICAgICB9DQo+ICANCj4gICAgLyogU2F2 ZSB0aGUgb3JpZ2luYWwgY29udGVudHMgb2YgdGhlIGNvcHkgYXJlYS4gICov DQo+IC0gIGRpc3BsYWNlZC0+c3RlcF9zYXZlZF9jb3B5ID0gKGdkYl9ieXRl ICopIHhtYWxsb2MgKGxlbik7DQo+ICsgIGlmIChkaXNwbGFjZWQtPnN0ZXBf c2F2ZWRfY29weSA9PSBOVUxMKQ0KPiArICAgIGRpc3BsYWNlZC0+c3RlcF9z YXZlZF9jb3B5ID0gKGdkYl9ieXRlICopIHhtYWxsb2MgKGxlbik7DQo+ICsg IC8qIEV2ZW4gaWYgd2UgaGF2ZSBub3QgYWxsb2NhdGVkIHN0ZXBfc2F2ZWRf Y29weSBub3csIG1ha2UgYQ0KPiArICAgICAodGVtcG9yYXJ5KSBjbGVhbnVw IGZvciBpdCwgaW4gY2FzZSB0aGUgc2V0dXAgYmVsb3cgZmFpbHMgdG8NCj4g KyAgICAgY29tcGxldGUgdGhlIGNvcHkuICAqLw0KPiAgICBpZ25vcmVfY2xl YW51cHMgPSBtYWtlX2NsZWFudXAgKGZyZWVfY3VycmVudF9jb250ZW50cywN Cj4gIAkJCQkgICZkaXNwbGFjZWQtPnN0ZXBfc2F2ZWRfY29weSk7DQo+ICAg IHN0YXR1cyA9IHRhcmdldF9yZWFkX21lbW9yeSAoY29weSwgZGlzcGxhY2Vk LT5zdGVwX3NhdmVkX2NvcHksIGxlbik7DQo+IA0KDQpGcm9tIHdoYXQgSSB1 bmRlcnN0YW5kLCB0aGUgYWxsb2NhdGlvbiBtb2RlbCB5b3UgcHJvcG9zZSBp biB0aGlzIHBhdGNoIGlzIHRvDQphbGxvY2F0ZSBhIGJ1ZmZlciB0aGUgZmly c3QgdGltZSB3ZSBkbyBhIGRpc3BsYWNlZCBzdGVwIGZvciBhbiBpbmZlcmlv ciBhbmQNCmZyZWUgaXQgd2hlbiB0aGUgaW5mZXJpb3IgZXhpdHMuICBUaGUg YWxsb2NhdGVkIHNpemUgaXMNCg0KICBsZW4gPSBnZGJhcmNoX21heF9pbnNu X2xlbmd0aCAoZ2RiYXJjaCk7DQoNCkdpdmVuIHRoYXQgdGhlcmUgY2FuIGJl IG11bHRpcGxlIGFyY2hpdGVjdHVyZXMgaW5zaWRlIGEgc2luZ2xlIGluZmVy aW9yLCBjYW4NCnRoZSByZXF1aXJlZCBidWZmZXIgc2l6ZSBjaGFuZ2UgYmV0 d2VlbiBtdWx0aXBsZSBkaXNwbGFjZWQgc3RlcD8NCg0KQWxzbywgaWYgZnJl ZWluZyB0aGUgYnVmZmVyIG9uIGluZmVyaW9yIGV4aXQgaXMgaW5kZWVkIHdo YXQgd2Ugd2FudCB0byBkbywgd2h5IGRvDQp3ZSBuZWVkIHRoZSBhYm92ZSBj bGVhbnVwPyAgRXZlbiBpZiB0aGUgc2V0dXAgZmFpbHMsIHNob3VsZG4ndCBi ZSBmaW5lIHRvIGtlZXAgdGhlIGJ1ZmZlcg0KYWxsb2NhdGVkPw0KDQpTaW1v bg0K >From gdb-patches-return-152261-listarch-gdb-patches=sources.redhat.com@sourceware.org Mon Nov 12 16:22:23 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 39699 invoked by alias); 12 Nov 2018 16:22:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 38152 invoked by uid 89); 12 Nov 2018 16:22:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Nov 2018 16:22:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1542039739; x=1544631739; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=kRycQ69xo8tDwTmo7+FPrLxShcoEm0yz/ua8er09ELc=; b=O86SqTUfgNX+Yz1+cgdpFxJZgf3amSBC5Zo+hTRlXNWrru17MsUO6djWymLGdlVV F+M7TuYhnfJbW7bdoXrH4YzFK8NBNWxjmDX/G50yQNVYLPmvvM7/RXWcXxoGS6a9 j5RC4D+gt/NVNoy8nGmASuUHWU7bVlPEGh3hn99vwSc=; Received: from ESESSMB504.ericsson.se (Unknown_Domain [153.88.183.122]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id 4F.DD.17348.BB8A9EB5; Mon, 12 Nov 2018 17:22:19 +0100 (CET) Received: from ESESSMR503.ericsson.se (153.88.183.112) by ESESSMB504.ericsson.se (153.88.183.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Mon, 12 Nov 2018 17:22:18 +0100 Received: from ESESBMB501.ericsson.se (153.88.183.168) by ESESSMR503.ericsson.se (153.88.183.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Mon, 12 Nov 2018 17:22:18 +0100 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB501.ericsson.se (153.88.183.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Mon, 12 Nov 2018 17:22:18 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kRycQ69xo8tDwTmo7+FPrLxShcoEm0yz/ua8er09ELc=; b=ZqBaD0Ddi67OzM791OzIszPhzKedYfLP9b+C85QTCKUmH+tr7bJ/lTY92ilcetKcABwQULuLjybcS1Z9V6H3c/aVFD0ltywaAZ0TV13iSZuNPSKCAEKB1ObZhVSeCksl3rrcd8nUbC/izjIiuy96J4Lovz/D6hF8Tt1eWKs0W8k= Received: from BYAPR15MB2390.namprd15.prod.outlook.com (52.135.198.30) by BYAPR15MB2391.namprd15.prod.outlook.com (52.135.198.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.21; Mon, 12 Nov 2018 16:22:15 +0000 Received: from BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::649a:ddbf:ecc5:1f0a]) by BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::649a:ddbf:ecc5:1f0a%3]) with mapi id 15.20.1294.044; Mon, 12 Nov 2018 16:22:15 +0000 From: Simon Marchi To: David Blaikie , Philippe Waroquiers CC: "gdb-patches@sourceware.org" Subject: Re: [RFAv2] Fix leak in displaced step. Date: Mon, 12 Nov 2018 16:22:00 -0000 Message-ID: <80b01a03-9dac-3345-374e-3c1c4eb8ad3a@ericsson.com> References: <20181111121137.6832-1-philippe.waroquiers@skynet.be> In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Content-Type: text/plain; charset="utf-8" Content-ID: <5CBAF554F583B84B94B8D12C2C7047AE@namprd15.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Return-Path: simon.marchi@ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00212.txt.bz2 Content-length: 793 T24gMjAxOC0xMS0xMiAxMDozNCBhLm0uLCBEYXZpZCBCbGFpa2llIHdyb3Rl Og0KPiBBbnkgY2hhbmNlIHRoaXMgY291bGQgdXNlIHVuaXF1ZV94bWFsbG9j X3B0ciB0byByZWR1Y2UgdGhlIHJpc2sgb2YgbGVha2luZw0KPiBhIGJpdD8g KEkgZ3Vlc3MgdGhhdCdkIHByb2JhYmx5IG1lYW4gaGFuZGxpbmcgdGhlIG93 bmVyc2hpcCBvZg0KPiBkaXNwbGFjZWRfc3RlcF9pbmZlcm9yaW9yX3N0YXRl LCBzaW5jZSBpdCdkIHRoZW4gaGF2ZSBhIG5vbi10cml2aWFsIGR0b3IsDQo+ IHNvIGl0IGNvdWxkbid0IGp1c3QgYmUgeG1hbGxvYy94ZnJlZSdkIGFuZCB3 b3VsZCBuZWVkIHNpbWlsYXINCj4gdW5pcXVlX3htYWxsb2NfcHRyIGhhbmRs aW5nLCBldGM/KQ0KDQpJIHRoaW5rIGl0IHdvdWxkIGJlIHRoZSByaWdodCB3 YXksIHllcy4gIElmIHdlIG5lZWQgdGhlIGJ1ZmZlciB0byBiZSByZXNpemFi bGUsDQp3ZSBjb3VsZCB1c2UgYSB2ZWN0b3IgKGdkYjo6Ynl0ZV92ZWN0b3Ip LCBidXQgaW4gYW55IGNhc2UNCmRpc3BsYWNlZF9zdGVwX2luZmVyaW9yX3N0 YXRlIHdvdWxkIG5lZWQgdGhlIHNhbWUgdHJlYXRtZW50Lg0KDQpTaW1vbg0K >From gdb-patches-return-152262-listarch-gdb-patches=sources.redhat.com@sourceware.org Mon Nov 12 19:01:04 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 124195 invoked by alias); 12 Nov 2018 19:00:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 122493 invoked by uid 89); 12 Nov 2018 19:00:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Nov 2018 19:00:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1542049206; x=1544641206; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=lmsEBw7BESGYfReqrQ22F5Kmvw796v17gY7/HrcnxdU=; b=btluBOY0p0bwMXpWjQU26EKXtfLXrGcZjiMv/X8NnjP6+QBzeG0Mu0wHJ8WUTaey Igm+j1YPl+Z5zLFk5urXoFFoLyda+wMSu7VD0EeTOuvQa+XQ//B/YSEEpcaEcYtz PGxEQJzyQCVt1A/scuUMIK0gWuozl1ttHTbUpMe6YF4=; Received: from ESESSMB505.ericsson.se (Unknown_Domain [153.88.183.123]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id 31.73.17348.6BDC9EB5; Mon, 12 Nov 2018 20:00:06 +0100 (CET) Received: from ESESBMB501.ericsson.se (153.88.183.168) by ESESSMB505.ericsson.se (153.88.183.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Mon, 12 Nov 2018 20:00:06 +0100 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB501.ericsson.se (153.88.183.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Mon, 12 Nov 2018 20:00:06 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7wjjnkWTeVXTegBgdBoHfUNfxZq1akUzlQSUhdH9Q98=; b=iutJD6+5b3MqrNzAvB/KlLtKiXYRl1yoTGhtkw7h+RhD6KHtdI25xA3LxD5Wy1NEYP0FQLU9rWHpbTsCuCdmMHZylzUlOIrBJUFo5AKXQzi2bLLhz4m6WF9yane5xkciCJ/mLvQjALVq3BFToSLyLUExxEU2712cXDheI3ZhsNY= Received: from BYAPR15MB2390.namprd15.prod.outlook.com (52.135.198.30) by BYAPR15MB2264.namprd15.prod.outlook.com (52.135.197.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.27; Mon, 12 Nov 2018 19:00:03 +0000 Received: from BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::649a:ddbf:ecc5:1f0a]) by BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::649a:ddbf:ecc5:1f0a%3]) with mapi id 15.20.1294.044; Mon, 12 Nov 2018 19:00:03 +0000 From: Simon Marchi To: "gdb-patches@sourceware.org" CC: Simon Marchi Subject: [PATCH] Use std::forward_list for displaced_step_inferior_states Date: Mon, 12 Nov 2018 19:00:00 -0000 Message-ID: <20181112185945.24599-1-simon.marchi@ericsson.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Return-Path: simon.marchi@ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00213.txt.bz2 Content-length: 4005 Use std::forward_list instead of manually implemented list. This simplifies a bit the code, especially around removal. Regtested on the buildbot. There are some failures as always, but I think they are unrelated. gdb/ChangeLog: * infrun.c (displaced_step_inferior_states): Change type to std::forward_list. (get_displaced_stepping_state): Adjust. (displaced_step_in_progress_any_inferior): Adjust. (add_displaced_stepping_state): Adjust. (remove_displaced_stepping_state): Adjust. --- gdb/infrun.c | 80 +++++++++++++++++++++++----------------------------- 1 file changed, 35 insertions(+), 45 deletions(-) diff --git a/gdb/infrun.c b/gdb/infrun.c index 9473d1f20f6..1c48740404e 100644 --- a/gdb/infrun.c +++ b/gdb/infrun.c @@ -1516,39 +1516,36 @@ struct displaced_step_inferior_state =20 /* The list of states of processes involved in displaced stepping presently. */ -static struct displaced_step_inferior_state *displaced_step_inferior_state= s; +static std::forward_list + displaced_step_inferior_states; =20 /* Get the displaced stepping state of process PID. */ =20 -static struct displaced_step_inferior_state * +static displaced_step_inferior_state * get_displaced_stepping_state (inferior *inf) { - struct displaced_step_inferior_state *state; - - for (state =3D displaced_step_inferior_states; - state !=3D NULL; - state =3D state->next) - if (state->inf =3D=3D inf) - return state; + for (auto *state : displaced_step_inferior_states) + { + if (state->inf =3D=3D inf) + return state; + } =20 - return NULL; + return nullptr; } =20 /* Returns true if any inferior has a thread doing a displaced step. */ =20 -static int -displaced_step_in_progress_any_inferior (void) +static bool +displaced_step_in_progress_any_inferior () { - struct displaced_step_inferior_state *state; - - for (state =3D displaced_step_inferior_states; - state !=3D NULL; - state =3D state->next) - if (state->step_thread !=3D nullptr) - return 1; + for (auto *state : displaced_step_inferior_states) + { + if (state->step_thread !=3D nullptr) + return true; + } =20 - return 0; + return false; } =20 /* Return true if thread represented by PTID is doing a displaced @@ -1584,21 +1581,19 @@ displaced_step_in_progress (inferior *inf) stepping state list, or return a pointer to an already existing entry, if it already exists. Never returns NULL. */ =20 -static struct displaced_step_inferior_state * +static displaced_step_inferior_state * add_displaced_stepping_state (inferior *inf) { - struct displaced_step_inferior_state *state; + displaced_step_inferior_state *state + =3D get_displaced_stepping_state (inf); =20 - for (state =3D displaced_step_inferior_states; - state !=3D NULL; - state =3D state->next) - if (state->inf =3D=3D inf) - return state; + if (state !=3D nullptr) + return state; =20 state =3D XCNEW (struct displaced_step_inferior_state); state->inf =3D inf; - state->next =3D displaced_step_inferior_states; - displaced_step_inferior_states =3D state; + + displaced_step_inferior_states.push_front (state); =20 return state; } @@ -1627,24 +1622,19 @@ get_displaced_step_closure_by_addr (CORE_ADDR addr) static void remove_displaced_stepping_state (inferior *inf) { - struct displaced_step_inferior_state *it, **prev_next_p; - gdb_assert (inf !=3D nullptr); =20 - it =3D displaced_step_inferior_states; - prev_next_p =3D &displaced_step_inferior_states; - while (it) - { - if (it->inf =3D=3D inf) - { - *prev_next_p =3D it->next; - xfree (it); - return; - } - - prev_next_p =3D &it->next; - it =3D *prev_next_p; - } + displaced_step_inferior_states.remove_if + ([inf] (displaced_step_inferior_state *state) + { + if (state->inf =3D=3D inf) + { + xfree (state); + return true; + } + else + return false; + }); } =20 static void --=20 2.19.1