From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29298 invoked by alias); 18 Apr 2013 10:30:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29273 invoked by uid 89); 18 Apr 2013 10:30:28 -0000 X-Spam-SWARE-Status: No, score=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 18 Apr 2013 10:30:28 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3IAUMWv030001 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 18 Apr 2013 06:30:27 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3IAU7fp021865; Thu, 18 Apr 2013 06:30:13 -0400 Message-ID: <516FCB2F.60002@redhat.com> Date: Fri, 19 Apr 2013 14:13:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [PATCH 00/26] Make GDB -Wpointer-sign clean. References: <20130411225847.16791.29283.stgit@brno.lan> <87txnbhhw5.fsf@fleche.redhat.com> In-Reply-To: <87txnbhhw5.fsf@fleche.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-04/txt/msg00567.txt.bz2 On 04/12/2013 04:45 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> This makes GDB -Wpointer-sign clean on x86_64 GNU/Linux, > Pedro> --enable-targets=all. Once this is in, and perhaps a couple hosts > Pedro> more are clean too (mingw and i386 GNU/Linux at least; haven't tried > Pedro> those), I'll propose enabling the switch by default. > > Thanks. I think the sooner it is enabled, the better. > Enabling reduces the chances for bit-rot, and fixing up any build > problems looks very easy. Indeed. > Pedro> I'm hoping this sort of split makes review easy and allows quick > Pedro> turnaround as consequence. > > I skimmed through all the patches and read ones more deeply where I know > the code well. It all looks good to me. Thanks. Unless I hear further comments, I'll check this in soon. -- Pedro Alves