From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6966 invoked by alias); 17 Apr 2013 12:54:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6921 invoked by uid 89); 17 Apr 2013 12:54:41 -0000 X-Spam-SWARE-Status: No, score=-8.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 17 Apr 2013 12:54:41 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3HCscKk004510 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 17 Apr 2013 08:54:38 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3HCsZrr014123; Wed, 17 Apr 2013 08:54:36 -0400 Message-ID: <516E9B8B.5000809@redhat.com> Date: Wed, 17 Apr 2013 17:02:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: mbilal CC: hafiz_abid@mentor.com, gdb-patches@sourceware.org, tromey@redhat.com, schwab@suse.de Subject: Re: [patch] patch for review of PR gdb/10462 References: <516D3B30.6080501@codesourcery.com> <516E67FE.5070301@codesourcery.com> <516E9561.8090102@codesourcery.com> In-Reply-To: <516E9561.8090102@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-04/txt/msg00530.txt.bz2 On 04/17/2013 01:28 PM, mbilal wrote: > --- gdb.base/default.exp 15 Apr 2013 18:09:02 -0000 1.64 > +++ gdb.base/default.exp 17 Apr 2013 12:18:38 -0000 BTW, is there a rationale for putting this in default.exp, which is about default actions of commands? I think setshow.exp might make more sense. > +#test argument must be preceded by space > +foreach x {"history file" "solib-search-path" "data-directory"} { > + foreach y {"/home/" "." "~/home" "=home"} { > + gdb_test "set $x$y" "Argument must be preceded by space." \ > + "check space before argument" > + } The uniqueness issue is still here: http://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Make_sure_test_messages_are_unique Is there a reason gdb_test_no_output "set $x $y" "set $x $y" was removed in this version? -- Pedro Alves