From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2725 invoked by alias); 16 Apr 2013 15:44:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2682 invoked by uid 89); 16 Apr 2013 15:44:04 -0000 X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from na3sys009aog101.obsmtp.com (HELO na3sys009aog101.obsmtp.com) (74.125.149.67) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Tue, 16 Apr 2013 15:44:04 +0000 Received: from mx10.qnx.com ([209.226.137.110]) (using TLSv1) by na3sys009aob101.postini.com ([74.125.148.12]) with SMTP ID DSNKUW1xvN256pHJ3JP+f4KjKgqdMLpbIbm/@postini.com; Tue, 16 Apr 2013 08:44:03 PDT Received: by mx10.qnx.com (Postfix, from userid 500) id 3B8F920E43; Tue, 16 Apr 2013 11:43:56 -0400 (EDT) Received: from exhts.ott.qnx.com (exch2 [10.222.2.136]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mx10.qnx.com (Postfix) with ESMTPS id 1689A1FD6E; Tue, 16 Apr 2013 11:43:56 -0400 (EDT) Received: from [10.222.96.215] (10.222.2.5) by EXCH2.ott.qnx.com (10.222.2.136) with Microsoft SMTP Server (TLS) id 14.2.318.4; Tue, 16 Apr 2013 11:43:55 -0400 Message-ID: <516D6AD6.50909@qnx.com> Date: Tue, 16 Apr 2013 17:19:00 -0000 From: Aleksandar Ristovski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Jan Kratochvil CC: Subject: Re: [PATCH 4/8] Prepare linux_find_memory_regions_full & co. for move References: <1365521265-28870-1-git-send-email-ARistovski@qnx.com> <1365521265-28870-5-git-send-email-ARistovski@qnx.com> <20130414141556.GB23227@host2.jankratochvil.net> In-Reply-To: <20130414141556.GB23227@host2.jankratochvil.net> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-04/txt/msg00483.txt.bz2 On 13-04-14 10:15 AM, Jan Kratochvil wrote: > On Tue, 09 Apr 2013 17:27:41 +0200, Aleksandar Ristovski wrote: > [...] >> --- a/gdb/target.c >> +++ b/gdb/target.c >> @@ -3476,55 +3476,67 @@ target_fileio_close_cleanup (void *opaque) >> target_fileio_close (fd, &target_errno); >> } >> >> +/* Helper for target_fileio_read_alloc_1 to make it interruptible. */ > > Here should be added (reason: so that one can easily find all the > read_alloc_pread_ftype instances): > > static read_alloc_pread_ftype target_fileio_read_alloc_1_pread; > > (And move the read_alloc_pread_ftype definition above.) Ok. >> +typedef int (read_alloc_pread_ftype) (int handle, gdb_byte *read_buf, int len, >> + ULONGEST offset, int *target_errno); > > Use tabs. Ok. > > ... > > > Here could be (so that one can easily find all the read_stralloc_func_ftype > instances): > > static read_stralloc_func_ftype target_fileio_read_alloc_1; > > (And move the read_stralloc_func_ftype definition above.) Ok. Thanks, Aleksandar