From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24802 invoked by alias); 12 Apr 2013 14:56:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24792 invoked by uid 89); 12 Apr 2013 14:56:30 -0000 X-Spam-SWARE-Status: No, score=-8.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 12 Apr 2013 14:56:30 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3CEuSvS017933 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 12 Apr 2013 10:56:28 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r3CEuQaI003764; Fri, 12 Apr 2013 10:56:27 -0400 Message-ID: <5168209A.8060606@redhat.com> Date: Fri, 12 Apr 2013 20:48:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 0/7 V2] Range stepping References: <1363006291-13334-1-git-send-email-yao@codesourcery.com> <1365648222-12540-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1365648222-12540-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-04/txt/msg00391.txt.bz2 On 04/11/2013 03:43 AM, Yao Qi wrote: > This is the V2 of range stepping series. V1 can be found here > . > > There are some updates in V2: > > - Rebase patches on GDB trunk, and resolve conflicts. > - Use phex_nz instead of hexnumstr to get the address. It fixes a > bug on mips target when sending address to the remote target. > - Define an internalvar range_stepping_counter and increment it each > time GDB does range-stepping, so that in the test, we don't have to > turn 'remote debug' on and parse the RSP packets. During the test, > we find that it is unsafe to turn the debugging output on, because it > may blow up the gdb.log. > > Patch 1,2,3,7 are unchanged. > > The whole series is tested on x86_64-linux, native and gdbserver. Thanks! As I'm no longer much distracted with 7.6 things or that dreaded -Wpointer-sign thing, I've resumed review/hacking on this. I really really want to get this over with, but please bear with me. :-) -- Pedro Alves