From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32491 invoked by alias); 11 Apr 2013 10:36:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32359 invoked by uid 89); 11 Apr 2013 10:36:50 -0000 X-Spam-SWARE-Status: No, score=-8.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 11 Apr 2013 10:36:50 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3BAamBU021675 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 11 Apr 2013 06:36:49 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3BAalXs024239; Thu, 11 Apr 2013 06:36:47 -0400 Message-ID: <5166923E.1070406@redhat.com> Date: Thu, 11 Apr 2013 17:52:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 MIME-Version: 1.0 To: Jan Kratochvil CC: Tom Tromey , gdb-patches@sourceware.org Subject: auto-generated parts in posted patches (Re: [patch 2/2+rfc+doc] Install gcore by default (+new man page)) References: <20130407185443.GB15389@host2.jankratochvil.net> <83r4ilawlx.fsf@gnu.org> <20130408172841.GA28868@host2.jankratochvil.net> <87hajgua2o.fsf@fleche.redhat.com> <516424FE.4050307@redhat.com> <20130409165525.GA29570@host2.jankratochvil.net> <51654DF0.3090101@redhat.com> <20130410194910.GA3941@host2.jankratochvil.net> <20130411040309.GA20577@host2.jankratochvil.net> In-Reply-To: <20130411040309.GA20577@host2.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-04/txt/msg00326.txt.bz2 On 04/11/2013 05:03 AM, Jan Kratochvil wrote: > Forgot to state here were always replies one should strip all auto-generated > parts from posted patches - so I do it. But I find that inconvenient. It is > easier to skip a part of patch when reviewing it than to regenerate it > hopefully the same way as the patch submitter because the source tree requires > special autotools (old version + unpatched). I fully agree. It's also very useful to see the generated bits to check whether a submitter who has commit/write access is using the right versions of the tools to regenerate the patches, and check whether the correct set of files is being regenerated. -- Pedro Alves