Re: [PATCH] store trace default-collect to target [5/6] doc

Hui Zhu
2013-04-16T09:31:58Z

[-- Attachment #1: Type: text/plain, Size: 1365 bytes --]

Hi Eli,

Thanks for your review.

On Fri, Apr 12, 2013 at 1:52 AM, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Thu, 11 Apr 2013 14:19:03 +0800
>> From: Hui Zhu <hui_zhu@mentor.com>
>>
>> This patch is doc update for "QTDDCsrc" and "qTDC".
>
> Thanks.
>
>> +@item QTDDCsrc:@var{bytes}
>> +@cindex define default collect, remote request
>> +@cindex @samp{QTDDCsrc} packet
>> +@var{bytes} is the string, encoded in hexadecimal.
>> +It specify a source string of default collect.
> ^^^^^^^
> "specifies"
>
> By the way, why is it called a "source" string?

Because it is same with QTDPsrc: string, encoded in hexadecimal. I
think it is not very good for this part now. So I removed it.

>
>> +These packets request default collect on the target. Replies to
>> +this packet generally take the form of the @code{QTDDCsrc} packet that
>> +define default collect.
> ^^^^^^
> "defines"

Fixed.

>
>> +Replies:
>> +@table @samp
>> +@item DC@var{bytes}
>> +@var{bytes} is the string, encoded in hexadecimal. It take the form of
>> +the @code{QTDDCsrc} packet that define default collect.^^^^
> ^^^^^^
> "takes" and "defines"

Fixed.

>
> OK with those changes.

Post a new version. Please help me review.

Best,
Hui

2013-04-16 Hui Zhu <hui@codesourcery.com>

* gdb.texinfo (Tracepoint Packets) Add "QTDDCsrc" and "qTDC".

[-- Attachment #2: defc-doc.txt --]
[-- Type: text/plain, Size: 2108 bytes --]

--- a/NEWS
+++ b/NEWS
@@ -45,6 +45,14 @@ show remote trace-status-packet
** The -trace-save MI command can optionally save trace buffer in Common
Trace Format now.

+* New remote packets
+
+QTDDCsrc
+ Download trace default collect string to target.
+
+qTDC
+ Request target upload trace default collect.
+
*** Changes in GDB 7.6

* Target record has been renamed to record-full.
--- a/doc/gdb.texinfo
+++ b/doc/gdb.texinfo
@@ -37825,8 +37825,10 @@ encoded). @value{GDBN} will continue to
@itemx QTDP
@itemx QTDPsrc
@itemx QTDV
+@itemx QTDDCsrc
@itemx qTfP
@itemx qTfV
+@itemx qTDC
@itemx QTFrame
@itemx qTMinFTPILen

@@ -38415,6 +38417,22 @@ the option of not using this packet for
target should simply create the trace state variables as they are
mentioned in expressions.

+@item QTDDCsrc:@var{bytes}
+@cindex define default collect, remote request
+@cindex @samp{QTDDCsrc} packet
+@var{bytes} is the string, encoded in hexadecimal.
+It specifies a string of default collect.
+The target does not need to do anything with source strings except
+report them back as part of the replies to the @samp{qTDC} query packets.
+
+Replies:
+@table @samp
+@item OK
+The packet was understood and carried out.
+@item @w{}
+The packet was not recognized.
+@end table
+
@item QTFrame:@var{n}
@cindex @samp{QTFrame} packet
Select the @var{n}'th tracepoint frame from the buffer, and use the
@@ -38670,6 +38688,24 @@ and multiple @code{qTsV} to get addition
these packets follow the syntax of the @code{QTDV} packets that define
trace state variables.

+@item qTDC
+@cindex @samp{qTDC} packet
+@itemx qTDC
+@cindex @samp{qTDC} packet
+These packets request default collect on the target. Replies to
+this packet generally take the form of the @code{QTDDCsrc} packet that
+defines default collect.
+
+Replies:
+@table @samp
+@item DC@var{bytes}
+@var{bytes} is the string, encoded in hexadecimal. It takes the form of
+the @code{QTDDCsrc} packet that defines default collect.
+
+@item @w{}
+The packet was not recognized.
+@end table
+
@item qTfSTM
@itemx qTsSTM
@anchor{qTfSTM}