Re: [patch] validate binary before use

Jan Kratochvil
2013-04-03T19:34:35Z

On Tue, 02 Apr 2013 18:24:18 +0200, Aleksandar Ristovski wrote:
> >>+ const CORE_ADDR sect_lma = l_addr + bfd_section_vma (so->abfd, asect);
> >
> >"lma" is irrelevant here, it needs to be VMA as you do runtime
> >target_read_memory for that address.
>
> [AR] I read "lma" as load memory address, i.e. address where it is
> actually loaded. This is to differentiate load address from virtual
> address as set by the link-editor.

It is no longer in the code but LMA was confusing, LMA is an established term
in bfd scope with a different meaning:
$ info '(ld)Output Section LMA'

This is not yet a full review.

Thanks,
Jan