From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9890 invoked by alias); 27 Mar 2013 02:14:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9478 invoked by uid 89); 27 Mar 2013 02:14:42 -0000 X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 27 Mar 2013 02:14:39 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1UKfsr-0006Ax-5t from Yao_Qi@mentor.com ; Tue, 26 Mar 2013 19:14:37 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 26 Mar 2013 19:14:36 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Tue, 26 Mar 2013 19:14:36 -0700 Message-ID: <515255BE.4010502@codesourcery.com> Date: Wed, 27 Mar 2013 08:54:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Pedro Alves CC: , Subject: Re: Change "set history size" back to signed (Re: [committed]: [PATCH 1/3] var_integer -> var_uinteger) References: <7A6A55B4-0293-4AD6-AB1F-B3169F8ADCC1@cs.umd.edu> <1344871663-915-1-git-send-email-yao@codesourcery.com> <1344871663-915-2-git-send-email-yao@codesourcery.com> <20534.29766.629459.204573@ruffy2.mtv.corp.google.com> <50372591.7080404@codesourcery.com> <20535.46196.619465.922388@ruffy2.mtv.corp.google.com> <503B476F.50805@codesourcery.com> <20539.61738.119545.634687@ruffy2.mtv.corp.google.com> <503CD0F7.20906@codesourcery.com> <5150A09D.3090202@redhat.com> <515176BB.4000702@codesourcery.com> <5151C9DF.6030303@redhat.com> In-Reply-To: <5151C9DF.6030303@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2013-03/txt/msg01000.txt.bz2 On 03/27/2013 12:16 AM, Pedro Alves wrote: > Anyway, I care more about the exported user interface than > the implementation. If we're staying with unsigned, > then let's rename the variable to at least make it more > obvious that this variable is not one of GNU history's > public variables. > Indeed. @@ -1381,19 +1384,9 @@ show_commands (char *args, int from_tty) /* The first command in the history which doesn't exist (i.e. one more than the number of the last command). Relative to history_base. */ - unsigned int hist_len; + int hist_len = history_length; Probably, we can replace local variable 'hist_len' with 'history_length' in function show_commands. Anyway, the patch looks pretty good. -- Yao (齐尧)